Skip to content

Simplify copyright year verification#36651

Open
utafrali wants to merge 1 commit intokubernetes:masterfrom
utafrali:fix/issue-36643-stop-setting-copyright-year-for-2026
Open

Simplify copyright year verification#36651
utafrali wants to merge 1 commit intokubernetes:masterfrom
utafrali:fix/issue-36643-stop-setting-copyright-year-for-2026

Conversation

@utafrali
Copy link

Replace the dynamic year range logic with a simple regex that matches any year starting with 20. Removes the datetime import and avoids needing to update this every year. Fixes #36643.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Mar 13, 2026

CLA Signed
The committers listed above are authorized under a signed CLA.

  • ✅ login: utafrali / name: Uğur Tafralı (58f6c6d)

@k8s-ci-robot
Copy link
Contributor

Welcome @utafrali!

It looks like this is your first PR to kubernetes/test-infra 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/test-infra has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: utafrali
Once this PR has been reviewed and has the lgtm label, please assign upodroid for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the sig/testing Categorizes an issue or PR as relevant to SIG Testing. label Mar 13, 2026
@k8s-ci-robot k8s-ci-robot requested review from aojea and upodroid March 13, 2026 11:35
@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 13, 2026
@k8s-ci-robot
Copy link
Contributor

Hi @utafrali. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Mar 13, 2026
@SergeyKanzhelev
Copy link
Member

Fixes #36643.

This PR doesn't really fix the issue, does it? The ask was to allow to not set any year at all

@BenTheElder
Copy link
Member

Replace the dynamic year range logic with a simple regex that matches any year starting with 20. Removes the datetime import and avoids needing to update this every year. Fixes #36643.

Er, the requirement is that we actually stop including the year for new files, but allow old files.

See the example fix for another repo, linked in the issue.

@utafrali
Copy link
Author

Done, pushed the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

stop setting copyright year for 2026+

4 participants