Skip to content

Conversation

lmktfy
Copy link
Contributor

@lmktfy lmktfy commented Aug 10, 2025

Description

Update the front matter for Japanese pages so that if we align more with Docsy, the top nav still works how we want. Currently, the top nav sections are hard coded:

Original vs preview (no visible difference; this is an enabling change)

Issue

Helps with issues #41171 and #50228

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/localization General issues or PRs related to localization labels Aug 10, 2025
@k8s-ci-robot k8s-ci-robot requested review from atoato88 and kakts August 10, 2025 21:46
@k8s-ci-robot k8s-ci-robot added language/ja Issues or PRs related to Japanese language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 10, 2025
Copy link

netlify bot commented Aug 10, 2025

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 436f1e2
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-io-main-staging/deploys/689ba94fd81b1f0008ec88e2
😎 Deploy Preview https://deploy-preview-51875--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@lmktfy lmktfy marked this pull request as ready for review August 10, 2025 21:59
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 10, 2025
@k8s-ci-robot k8s-ci-robot requested a review from bells17 August 10, 2025 21:59
Copy link
Member

@Okabe-Junya Okabe-Junya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, almost LGTM

Please check t-inu's comment

@Okabe-Junya
Copy link
Member

/assign
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Okabe-Junya

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 11, 2025
@lmktfy lmktfy force-pushed the 20250810_top_menu_ja branch from 4fbf9c4 to 436f1e2 Compare August 12, 2025 20:51
Copy link
Member

@t-inu t-inu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 13, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: a53843b06d0720e03c5c2aa93f8133157b73d439

@k8s-ci-robot k8s-ci-robot merged commit dd63f42 into kubernetes:main Aug 13, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/localization General issues or PRs related to localization cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/ja Issues or PRs related to Japanese language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants