-
Notifications
You must be signed in to change notification settings - Fork 15k
Update Japanese to support Docsy-style menus #51875
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, almost LGTM
Please check t-inu's comment
/assign |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Okabe-Junya The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
4fbf9c4
to
436f1e2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
/lgtm
LGTM label has been added. Git tree hash: a53843b06d0720e03c5c2aa93f8133157b73d439
|
Description
Update the front matter for Japanese pages so that if we align more with Docsy, the top nav still works how we want. Currently, the top nav sections are hard coded:
website/layouts/partials/navbar.html
Line 28 in c07ffdf
website/layouts/404.html
Line 9 in c07ffdf
Original vs preview (no visible difference; this is an enabling change)
Issue
Helps with issues #41171 and #50228