Drop spark example with archived link #52607
Conversation
|
Welcome @loucadufault! |
k8s-ci-robot
added
cncf-cla: no
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
@loucadufault Thanks you for your contribution. |
|
|
||
| One example of this pattern would be a Job which starts a Pod which runs a script that in turn | ||
| starts a Spark master controller (see [spark example](https://github.com/kubernetes/examples/tree/master/staging/spark/README.md)), | ||
| starts a Spark master controller (see [spark example](https://github.com/kubernetes/examples/tree/master/_archived/spark/README.md)), |
There was a problem hiding this comment.
As in previous examples, I'd prefer we drop these links, rather than updating them. Everything that moved to _archived directory is not maintained and usually outdated. So the recommendation from sig-apps is to drop them.
There was a problem hiding this comment.
@soltysh just to confirm, would you say that we should take out the spark example text and link listed altogether? (meaning, just having the text "starts a Spark master controller") – or should that text also be omitted?
There was a problem hiding this comment.
+1 to dropping these. The examples are archived because they are no longer maintained. Keeping links to them from current documentation results in issues and PRs from folks trying to bring them up to date, which is counter to the idea of them being archived.
I would say if someone wants to add a new, updated example that can be linked to, then that would be awesome. But unless/until we have that, I agree it should just be dropped from the docs.
|
@loucadufault hello! thanks for your first contribution. however, we cannot move forward with this change without the CLA being signed. please find instructions on how to do so here: https://git.k8s.io/community/CLA.md |
|
/easycla |
k8s-ci-robot
added
cncf-cla: yes
loucadufault
changed the title
|
@soltysh @stmcginnis If you're good with the latest update that drops this example, then so is docs – thanks for taking another look |
|
Given it is old and archived, I think this makes sense. Ideally we would have a newer example we can point to, but that's kind of an ongoing need anyway. Thanks for cleaning this up! /lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 243835c50ae14f0b92b26824b5c1e4490d381e60
|
|
thanks @stmcginnis! and thank you @loucadufault for your contribution and for being open to feedback from maintainers 👏 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: natalisucks The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
7 participants
Description
Link to spark example points to a location which seems to have been moved to
_archived/folder in that repo, in this commit: kubernetes/examples@8b3fa9a