Skip to content

Conversation

kpbaks
Copy link

@kpbaks kpbaks commented Oct 4, 2025

Description

special not pecial

Issue

Closes: NA

@k8s-ci-robot k8s-ci-robot requested review from jpbetz and SataQiu October 4, 2025 13:53
@k8s-ci-robot k8s-ci-robot added area/localization General issues or PRs related to localization language/en Issues or PRs related to English language labels Oct 4, 2025
Copy link

linux-foundation-easycla bot commented Oct 4, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: kpbaks / name: Kristoffer Plagborg Bak Sørensen (23f5857)

@k8s-ci-robot k8s-ci-robot added language/zh Issues or PRs related to Chinese language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Oct 4, 2025
@k8s-ci-robot
Copy link
Contributor

Welcome @kpbaks!

It looks like this is your first PR to kubernetes/website 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/website has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 4, 2025
Copy link

netlify bot commented Oct 4, 2025

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 23f5857
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-io-main-staging/deploys/68e26d592f488a00083c336b
😎 Deploy Preview https://deploy-preview-52623--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Member

@Arhell Arhell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/easycla

@kpbaks
Copy link
Author

kpbaks commented Oct 5, 2025

/easycla

@dipesh-rawat
Copy link
Member

@kpbaks Thanks you for your contribution.
Could you please sign the CLA before the PR can be reviewed.
You can follow the steps documented here: CLA Steps

Copy link
Member

@dipesh-rawat dipesh-rawat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kpbaks It appears that this PR includes changes to files across multiple languages 'English' and 'Chinese'. However, docs follows different processes for each localization, and and we typically don't accept pull requests that impact multiple languages simultaneously. I would recommend modify only the primary website content (which means only English content) initially with this PR. After the merge of the English content, we could create separate pull request for the remaining language(s) to sync with 'en' changes. I hope this suggestion is helpful.

@dipesh-rawat
Copy link
Member

Explicit hold until this PR only covers one language (and the CLA is signed).

(Ok to unhold once that's done)
/hold

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Oct 5, 2025
@kpbaks kpbaks force-pushed the fix-typo-declarative-validation.md branch from 30307c4 to 23f5857 Compare October 5, 2025 13:06
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign nate-double-u for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dipesh-rawat
Copy link
Member

/remove-area localization
/remove-language zh

@k8s-ci-robot k8s-ci-robot removed area/localization General issues or PRs related to localization language/zh Issues or PRs related to Chinese language labels Oct 5, 2025
@dipesh-rawat
Copy link
Member

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 5, 2025
Copy link
Member

@dipesh-rawat dipesh-rawat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 5, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: f146bf30a3794cb2c7ab95223ca8c72555c047ed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants