-
Notifications
You must be signed in to change notification settings - Fork 15k
Fix references to removed feature gates #52626
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
✅ Pull request preview available for checking
To edit notification comments on pull requests, go to your Netlify project configuration. |
7a78128
to
1c7ef72
Compare
I changed my mind. We can, and I think we, should, change the feature gate shortcode. For example, for a removed feature gate, we can present a simple phrase I will open a PR to do that. I'm afraid I think it remains valuable to tell people when the feature went stable. |
I opened #52632 to show how I'd address this. I genuinely hope people like the idea. |
I don't think keeping the feature-state shortcode in a page is a sustainable approach. This is especially true for features that have been removed for several years. Considering that we cannot afford to distinguish "gates removed long ago" from "gates removed last year", stale feature-gate shortcode will make the pages more and more confusing. We can, for sure, add lengthy texts to articulate the difference between a GA'ed feature and a removed feature, and we can add more texts to differentiate "locked" ones from others. However, the added texts are not helping users in a meaningful way. They only lead to more confusion. I insist that we should add |
This PR is about an English site-wide fix to feature gate references.
We are still referencing some feature gates that have been removed.
The removal of a feature gate is a strong indicator that the relevant feature won't get changed in the near future unless some serious bugs are reported.
We don't want to unnecessarily remind user that a feature is stable.
A reminder of this kind only triggers a suspicion that something is not so "stable".
A "stable" feature doesn't needs to be reminded forever.
References to a feature gate that has been removed is a source of confusion to users.