Revise the rendering of feature state #52635
Open
+10
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
sig/docs
✅ Pull request preview available for checking
To edit notification comments on pull requests, go to your Netlify project configuration. |
lmktfy
reviewed
Oct 6, 2025
|
|
||
| [feature_gate_enabled] | ||
| other = "(enabled by default: {{ .enabled }})" | ||
| other = "(enabled by default)" |
There was a problem hiding this comment.
Caution: this might break localizations that still rely on the old text.
If we're OK with that, we can proceed.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lmktfy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/area web-development |
k8s-ci-robot
added
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the logic for rendering feature state.
Currently, a feature state is rendered as "enabled by default: true" or "enabled by default: false". A more user-friendly way to render it should be "enabled by default" or "disabled by default". This saves users some brain cells when reading the feature state.