Skip to content

Conversation

tengqm
Copy link
Contributor

@tengqm tengqm commented Oct 6, 2025

This PR contains three commits that collectively fix the example manifests and the test cases.

  • The first commit updates the go module dependency to work with v1.34 release;
  • The second commit fixes the example_test.go to include new manifests that were not tested;
  • The third commit contains some trivial changes to the manifests where the changes are to make sure the manifests can pass the validation logic.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 6, 2025
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Oct 6, 2025
Copy link

netlify bot commented Oct 6, 2025

Pull request preview available for checking

Name Link
🔨 Latest commit eaebf93
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-io-main-staging/deploys/68e368c0e727ec0008f1f0d6
😎 Deploy Preview https://deploy-preview-52636--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@stmcginnis
Copy link
Contributor

Thanks!

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 6, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 6b2ff6c5c1e00aaba7dc70d0f8dc46a8e55ba958

Copy link
Contributor

@lmktfy lmktfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lmktfy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 6, 2025
@k8s-ci-robot k8s-ci-robot merged commit 7866af8 into kubernetes:main Oct 6, 2025
6 checks passed
@tengqm tengqm deleted the fix-examples-test branch October 7, 2025 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants