Skip to content

KEP-5647: Stale informer docs#52901

Merged
k8s-ci-robot merged 1 commit intokubernetes:dev-1.36from
michaelasp:StaleInformerDocs
Apr 8, 2026
Merged

KEP-5647: Stale informer docs#52901
k8s-ci-robot merged 1 commit intokubernetes:dev-1.36from
michaelasp:StaleInformerDocs

Conversation

@michaelasp
Copy link
Copy Markdown
Contributor

@michaelasp michaelasp commented Oct 23, 2025

Description

Add feature gate documentation for KEP-5647

Issue

kubernetes/enhancements#5647

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language labels Oct 23, 2025
@k8s-ci-robot k8s-ci-robot added sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 23, 2025
@michaelasp michaelasp changed the title Stale informer docs KEP-5647: Stale informer docs Oct 23, 2025
@michaelasp michaelasp mentioned this pull request Oct 23, 2025
Open
17 tasks
@netlify
Copy link
Copy Markdown

netlify bot commented Oct 23, 2025 •
edited
Loading

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 9cf0562
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-io-main-staging/deploys/69d3d82b2008c600089bf45f
😎 Deploy Preview https://deploy-preview-52901--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@Urvashi0109
Copy link
Copy Markdown
Contributor

Urvashi0109 commented Oct 23, 2025

@michaelasp We should consider setting the dev-1.35 branch as the target branch rather than the main branch for this pull request. Since the doc change is related to the feature in v1.35

@michaelasp michaelasp changed the base branch from main to dev-1.35 October 23, 2025 14:34
@netlify
Copy link
Copy Markdown

netlify bot commented Oct 23, 2025

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
🔨 Latest commit a179ecf
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-io-vnext-staging/deploys/68fa3d5a4561cd0008a0d578

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 23, 2025
@michaelasp
Copy link
Copy Markdown
Contributor Author

michaelasp commented Oct 23, 2025

@michaelasp We should consider setting the dev-1.35 branch as the target branch rather than the main branch for this pull request. Since the doc change is related to the feature in v1.35

Ah yep, done!

@k8s-triage-robot
Copy link
Copy Markdown

k8s-triage-robot commented Jan 22, 2026

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 22, 2026
@michaelasp
Copy link
Copy Markdown
Contributor Author

michaelasp commented Jan 27, 2026

/remove-lifecycle stale

This will be used for 1.36

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 27, 2026
@michaelasp michaelasp changed the base branch from dev-1.35 to dev-1.36 February 17, 2026 21:27
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 25, 2026
@michaelasp michaelasp marked this pull request as ready for review March 25, 2026 19:06
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 25, 2026
@k8s-ci-robot k8s-ci-robot requested a review from salaxander March 25, 2026 19:06
@michaelasp michaelasp requested a review from tengqm March 25, 2026 19:06
@k8s-ci-robot k8s-ci-robot requested a review from tengqm March 25, 2026 19:06
@liggitt
Copy link
Copy Markdown
Member

liggitt commented Mar 26, 2026

technical lgtm

lmktfy
lmktfy reviewed Apr 4, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@lmktfy lmktfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. I recommend fixes per the inline feedback.

@lmktfy lmktfy mentioned this pull request Apr 5, 2026
Open
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 6, 2026
@michaelasp michaelasp requested a review from lmktfy April 6, 2026 15:59
@reylejano
Copy link
Copy Markdown
Member

reylejano commented Apr 7, 2026

Thank you for addressing comments/reviews
/approve

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Apr 7, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: reylejano

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 7, 2026
@reylejano
Copy link
Copy Markdown
Member

reylejano commented Apr 8, 2026

This PR adds 6 feature gates but not how to use them. Are there related documentation PRs to include how to use these feature gates?

@michaelasp
Copy link
Copy Markdown
Contributor Author

michaelasp commented Apr 8, 2026

This PR adds 6 feature gates but not how to use them. Are there related documentation PRs to include how to use these feature gates?

They are on by default, these are mostly meant as an escape hatch in case something goes wrong. #54792 is a blog post that shows what they do and how controller authors can use them.

Overall however, this is meant to be a generally see through change, with no behavior changes visible for users.

@reylejano
Copy link
Copy Markdown
Member

reylejano commented Apr 8, 2026

/milestone 1.36

@k8s-ci-robot k8s-ci-robot added this to the 1.36 milestone Apr 8, 2026
lmktfy
lmktfy reviewed Apr 8, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@lmktfy lmktfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Technical details not checked; looks right, though.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 8, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Apr 8, 2026

LGTM label has been added.

DetailsGit tree hash: 868b3c50faf658acacde81d92eb9b3b407e828a0

@k8s-ci-robot k8s-ci-robot merged commit 416c4ce into kubernetes:dev-1.36 Apr 8, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lmktfy lmktfy lmktfy left review comments

@divya-mohan0209 divya-mohan0209 Awaiting requested review from divya-mohan0209

@nate-double-u nate-double-u Awaiting requested review from nate-double-u

@salaxander salaxander Awaiting requested review from salaxander

@tengqm tengqm Awaiting requested review from tengqm

Assignees

@lmktfy lmktfy

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

1.36

Development

Successfully merging this pull request may close these issues.

8 participants

@michaelasp @Urvashi0109 @k8s-triage-robot @liggitt @reylejano @k8s-ci-robot @tengqm @lmktfy