-
Notifications
You must be signed in to change notification settings - Fork 15.2k
Document node.alpha.kubernetes.io/ttl label #53892
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
When people write reviews (and, because this is open source, anyone can) the key question to considerbis: does this change make the documentation better than it started. This one is easy to say that about, so: |
|
|
||
| Type: Label | ||
|
|
||
| Example: `node.alpha.kubernetes.io/ttl: "0"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not really sure what this actually does, but registering it with an incomplete explanation is much better than not registering it at all.
|
Oops, I didn't notice the commit message. Do you know how to amend the commit @pmady? If you have amended it and are using the |
|
Here's how to fix the commit message: Document node.alpha.kubernetes.io/ttl label
Add documentation for the deprecated node.alpha.kubernetes.io/ttl label
in the Well-Known Labels, Annotations and Taints reference page.
This label was historically used by tools like minikube to set a
time-to-live value for nodes. The label is deprecated and has no effect
in current Kubernetes versions, but may still be set by older tools for
backward compatibility.
-
-Fixes #53889
-
-Signed-off-by: pmady <[email protected]>This doesn't need a DCO or commit message signoff. You did need to sign the CLA; I see that you have done so. |
2b44cbe to
90c56b4
Compare
|
@lmktfy fixed the commit message. Thanks |
|
@pmady this is still not fixed yet, look at the last line of your commit message. |
Add documentation for the deprecated node.alpha.kubernetes.io/ttl label in the Well-Known Labels, Annotations and Taints reference page. This label was historically used by tools like minikube to set a time-to-live value for nodes. The label is deprecated and has no effect in current Kubernetes versions, but may still be set by older tools for backward compatibility.
90c56b4 to
5865a31
Compare
|
/retest |
|
@pmady: Cannot trigger testing until a trusted user reviews the PR and leaves an DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/lgtm |
|
LGTM label has been added. DetailsGit tree hash: a419cbcd5e4e754caa58356d567966fb292c465c |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tengqm The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fixes #53889
This PR adds documentation for the deprecated node.alpha.kubernetes.io/ttl label in the Well-Known Labels, Annotations and Taints reference page.
What this PR does:
Why this is needed:
As mentioned in the issue, the Well-Known Labels, Annotations and Taints page serves as a coordination point for assigning values. It's important to register all labels that are or have been used, even deprecated ones, to maintain a complete reference.