Skip to content

Conversation

@pmady
Copy link
Contributor

@pmady pmady commented Jan 2, 2026

Fixes #53889

This PR adds documentation for the deprecated node.alpha.kubernetes.io/ttl label in the Well-Known Labels, Annotations and Taints reference page.

What this PR does:

  • Documents the node.alpha.kubernetes.io/ttl label that was historically used by tools like minikube
  • Marks it as deprecated with a clear note that it has no effect in current Kubernetes versions
  • Explains that it may still be set by older tools for backward compatibility

Why this is needed:

As mentioned in the issue, the Well-Known Labels, Annotations and Taints page serves as a coordination point for assigning values. It's important to register all labels that are or have been used, even deprecated ones, to maintain a complete reference.

@k8s-ci-robot k8s-ci-robot added do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. language/en Issues or PRs related to English language labels Jan 2, 2026
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 2, 2026
@netlify
Copy link

netlify bot commented Jan 2, 2026

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 129b019
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-io-main-staging/deploys/6962b5a9b0030000087c6a26
😎 Deploy Preview https://deploy-preview-53892--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@lmktfy
Copy link
Member

lmktfy commented Jan 3, 2026

When people write reviews (and, because this is open source, anyone can) the key question to considerbis: does this change make the documentation better than it started.

This one is easy to say that about, so:
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 3, 2026

Type: Label

Example: `node.alpha.kubernetes.io/ttl: "0"`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not really sure what this actually does, but registering it with an incomplete explanation is much better than not registering it at all.

@lmktfy
Copy link
Member

lmktfy commented Jan 3, 2026

Oops, I didn't notice the commit message.
/lgtm cancel
/approve cancel

Do you know how to amend the commit @pmady? If you have amended it and are using the git tool, you would then run git push --force-with-lease to replace the remote branch with your updated changes.

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 3, 2026
@k8s-ci-robot k8s-ci-robot requested a review from lmktfy January 3, 2026 11:08
@k8s-ci-robot k8s-ci-robot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 3, 2026
@lmktfy
Copy link
Member

lmktfy commented Jan 3, 2026

Here's how to fix the commit message:

 Document node.alpha.kubernetes.io/ttl label
    
 Add documentation for the deprecated node.alpha.kubernetes.io/ttl label
 in the Well-Known Labels, Annotations and Taints reference page.
     
 This label was historically used by tools like minikube to set a
 time-to-live value for nodes. The label is deprecated and has no effect
 in current Kubernetes versions, but may still be set by older tools for
 backward compatibility.
-   
-Fixes #53889
-   
-Signed-off-by: pmady <[email protected]>

This doesn't need a DCO or commit message signoff. You did need to sign the CLA; I see that you have done so.

@pmady pmady force-pushed the add-node-ttl-label branch from 2b44cbe to 90c56b4 Compare January 3, 2026 20:11
@pmady
Copy link
Contributor Author

pmady commented Jan 3, 2026

@lmktfy fixed the commit message. Thanks

@sshehrozali
Copy link

@pmady this is still not fixed yet, look at the last line of your commit message.

Add documentation for the deprecated node.alpha.kubernetes.io/ttl label
in the Well-Known Labels, Annotations and Taints reference page.

This label was historically used by tools like minikube to set a
time-to-live value for nodes. The label is deprecated and has no effect
in current Kubernetes versions, but may still be set by older tools for
backward compatibility.
@pmady pmady force-pushed the add-node-ttl-label branch from 90c56b4 to 5865a31 Compare January 10, 2026 20:22
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Jan 10, 2026
@pmady
Copy link
Contributor Author

pmady commented Jan 10, 2026

/retest

@k8s-ci-robot
Copy link
Contributor

@pmady: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@tengqm
Copy link
Contributor

tengqm commented Jan 11, 2026

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 11, 2026
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

DetailsGit tree hash: a419cbcd5e4e754caa58356d567966fb292c465c

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 11, 2026
@k8s-ci-robot k8s-ci-robot merged commit ef8ca9a into kubernetes:main Jan 11, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Document label node.alpha.kubernetes.io/ttl

5 participants