-
Notifications
You must be signed in to change notification settings - Fork 15.2k
[ja] Translate content/en/docs/tasks/administer-cluster/dns-horizontal-autoscaling.md #53919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ja] Translate content/en/docs/tasks/administer-cluster/dns-horizontal-autoscaling.md #53919
Conversation
…oscaling.md Signed-off-by: Pratik Mahalle <mahallepratik683@gmail.com>
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
kfess
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pratik-mahalle
Thank you for your contribution. While the overall translation looks good, we have guidelines for Japanese translation. Currently, many parts don't meet these guidelines. Could you please revise them to align with our guidelines?
ref: https://kubernetes.io/ja/docs/contribute/localization/
Japanese localization rules are as follows:
日本語文では、文章の途中で改行を行わない。句点「。」もしくは行末のコロン:で改行する
本ドキュメント内のページへのリンクは、日本語ページが存在していても、URLに/jaの追加は不要(HTMLへの変換時に自動判別されるようになったため)
既存の日本語ページで/jaが記載されている場合は、ページの最新化の際に削除する
各セクションの見出しを翻訳した場合は、その後ろに{#見出しID}の形式でアンカーリンクを設定する
例: ## リファレンス {#reference}
見出しIDは、英語ページでの見出しのパーマリンクを確認して、URLの#以降を使用する
英単語と日本語の間に半角スペースは不要
例: Kubernetesクラスター
カッコ()の前後にも半角スペースは不要
数字とアルファベットは半角で表記
記号類は感嘆符「!」と疑問符「?」のみ全角、それ以外は半角で表記
Signed-off-by: Pratik Mahalle <mahallepratik683@gmail.com>
|
Thank you for the suggestion @kfess, I have updated the docs as per your suggestion. Please have a look at it |
kfess
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pratik-mahalle
I've added some comments. Overall LGTM, but please check them.
content/ja/docs/tasks/administer-cluster/dns-horizontal-autoscaling.md
Outdated
Show resolved
Hide resolved
content/ja/docs/tasks/administer-cluster/dns-horizontal-autoscaling.md
Outdated
Show resolved
Hide resolved
content/ja/docs/tasks/administer-cluster/dns-horizontal-autoscaling.md
Outdated
Show resolved
Hide resolved
content/ja/docs/tasks/administer-cluster/dns-horizontal-autoscaling.md
Outdated
Show resolved
Hide resolved
content/ja/docs/tasks/administer-cluster/dns-horizontal-autoscaling.md
Outdated
Show resolved
Hide resolved
Signed-off-by: Pratik Mahalle <mahallepratik683@gmail.com>
Thanks for the feedback, I have updated the docs as per comments provided |
|
Thank you for the update. |
|
LGTM label has been added. DetailsGit tree hash: ced7a572ae93a40190901dca9f4c0532e5a60c33 |
|
/assign |
content/ja/docs/tasks/administer-cluster/dns-horizontal-autoscaling.md
Outdated
Show resolved
Hide resolved
content/ja/docs/tasks/administer-cluster/dns-horizontal-autoscaling.md
Outdated
Show resolved
Hide resolved
content/ja/docs/tasks/administer-cluster/dns-horizontal-autoscaling.md
Outdated
Show resolved
Hide resolved
|
Thank you for the review, @t-inu! I've applied all the suggested changes:
Changes have been pushed. Please take another look when you get a chance. 🙏 |
Signed-off-by: Pratik Mahalle <mahallepratik683@gmail.com>
Signed-off-by: Pratik Mahalle <mahallepratik683@gmail.com>
Signed-off-by: Pratik Mahalle <mahallepratik683@gmail.com>
t-inu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
/label tide/merge-method-squash
/lgtm
/approve
|
LGTM label has been added. DetailsGit tree hash: 275ca331c4d86d678bb8fab68a36a3e1adaa4828 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: t-inu The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it
This PR adds a Japanese translation for content/en/docs/tasks/administer-cluster/dns-horizontal-autoscaling.md.
Which issue(s) this PR fixes
Fixes #53610
Does this PR introduce a user-facing change?
None
/area localization
/language ja