feature-blog(ccm): new metric route_sync_total#54693
feature-blog(ccm): new metric route_sync_total#54693lukasmetzner wants to merge 6 commits intokubernetes:dev-1.36from
Conversation
k8s-ci-robot
added
the
do-not-merge/work-in-progress
k8s-ci-robot
added
the
area/blog
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
k8s-ci-robot
added
language/en
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
k8s-ci-robot
added
size/M
Signed-off-by: lukasmetzner <lukas.metzner@hetzner-cloud.de>
lukasmetzner
force-pushed
the
ccm-add-route-reconcile-metric
branch
from
cb21ffa to
d9b5a74
Compare
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
|
The technical details look good to me and match the changes for the KEP in the v1.36 milestone. I can not evaluate if the writing style matches expectations and if the content is relevant enough for a feature blog. /lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. DetailsGit tree hash: 95c137d47ec1ec5b6aec6336f1dc19e02ed6b471 |
elmiko
left a comment
elmiko
left a comment
There was a problem hiding this comment.
looking good, i have a couple minor suggestions.
k8s-ci-robot
removed
the
lgtm
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. DetailsGit tree hash: 85f08e24642472b1c3819cef3749fcc92c31012e |
k8s-ci-robot
removed
the
lgtm
Serenity611
left a comment
Serenity611
left a comment
There was a problem hiding this comment.
Reviewed for proofreading and adherence to style guide, it looks great! I made one small suggestion to how the Slack channel is displayed, up to you!
|
lgtm, holding on label since there is a comment outstanding. |
Co-authored-by: Susan Sica <90214772+Serenity611@users.noreply.github.com>
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. DetailsGit tree hash: a8fb67ee09712b943e9def7db23f1f95ff17290c |
|
Hi @lukasmetzner 👋 v1.36 Communications team here, @michaelasp as author of #54792, I'd like you to be a writing buddy for @lukasmetzner on this PR. Please:
|
michaelasp
left a comment
michaelasp
left a comment
There was a problem hiding this comment.
Hey @lukasmetzner! Reviewing as your writing buddy, lgtm overall, only suggestion might be a real world example.
| to the infrastructure provider, lowering pressure on rate-limited APIs and allowing operators | ||
| to make more efficient use of their available quota. | ||
|
|
||
| To A/B test this, compare `route_controller_route_sync_total` with the feature gate |
There was a problem hiding this comment.
Might be good to have an example of what the metric may look like and how to query and poke it in a running cluster? What's the rate of change usually with and without this feature enabled?
This seems like the metric should stay steady, maybe show that when we have the feature disabled it increments steadily and on the other side the metric should stay still until we update the routes.
There was a problem hiding this comment.
@michaelasp I have added a small example outlying the expected behavior of the metric with the feature gate enabled and disabled.
As this metric is part of the k8s.io/cloud-provider library, giving a concrete example about how to query this is not feasible here. This depends on the concrete cloud-controller-manager implementation of a cloud-provider.
k8s-ci-robot
removed
the
lgtm
k8s-ci-robot
added
cncf-cla: no
|
@Serenity611 Did you stop your contributions for CNCF? Shall I remove you from the commit? |
|
@lukasmetzner Oh my gosh, I am so sorry!! No, I am still contributing--there is something going on with the EasyCLA where it is suddenly (and for no apparent reason) trying to associate me with an email address that I have never used for project work. This happened a couple weeks ago and was allegedly resolved (though they still can't explain to me HOW this other email address was found and associated with my LF account), but now I see it's happening again. I have reopened the ticket and will push for this to be resolved promptly--I do not want to hold up the PR! Thank you so much for bringing this to my attention! |
|
/easycla |
1 similar comment
|
/easycla |
k8s-ci-robot
added
cncf-cla: yes
|
@lukasmetzner Okay, I think the issue with the CLA looking at a wrong email address for me has been fully resolved and this should not keep happening (fingers crossed.) My apologies for the delay! |
|
Hi @lukasmetzner 👋 -- this is @chadmcrowell from the v1.36 Communications Team! Just a friendly reminder that we are approaching the feature blog "ready for review" deadline: Monday, April 6. We ask you to have the blog in non-draft state, and all write-up to be complete, so that we can start the blog review from SIG Docs Blog team. If you have any questions or need help, please don't hesitate to reach out to me or any of the Communications Team members. We are here to help you! |
elmiko
left a comment
elmiko
left a comment
There was a problem hiding this comment.
apologies for the late review, i was on vacation after kubecon.
/lgtm
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. DetailsGit tree hash: d8228f5a11006873c1c458aa25ef5ad65ba9eb16 |
8 participants
Description
This feature blog shall introduce our new metric
route_controller_route_sync_total. Furthermore, it shall explain on how to use this, to A/B test the feature gateCloudControllerManagerWatchBasedRoutesReconciliation.