Skip to content

[fa] Remove kubeweekly shortcode from homepage#55276

Draft
mamrezb wants to merge 1 commit intokubernetes:dev-1.33-fa.1from
mamrezb:fix/remove-kubeweekly-fa
Draft

[fa] Remove kubeweekly shortcode from homepage#55276
mamrezb wants to merge 1 commit intokubernetes:dev-1.33-fa.1from
mamrezb:fix/remove-kubeweekly-fa

Conversation

@mamrezb
Copy link
Copy Markdown
Contributor

@mamrezb mamrezb commented Apr 6, 2026

Summary

  • Remove the deprecated {{< kubeweekly >}} shortcode call from the Farsi homepage
  • The KubeWeekly signup form has already been removed from main
  • The RTL overflow issue reported in #55093 (comment) resolves on its own once dev-1.33-fa.1 merges into main, as the legacy layout files causing it no longer exist there

Already removed from main. It caused horizontal overflow on RTL pages.
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 6, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign tengqm for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added area/localization General issues or PRs related to localization size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. language/fa Issues or PRs related to Persian language cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Apr 6, 2026
@netlify
Copy link
Copy Markdown

netlify bot commented Apr 6, 2026

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 20f4be7
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-io-main-staging/deploys/69d3cc83bd824c000808f1f8
😎 Deploy Preview https://deploy-preview-55276--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@xirehat
Copy link
Copy Markdown
Member

xirehat commented Apr 8, 2026

@mamrezb It seems still exist in main page, I think it's better to update Farsi main page like other localization(copy the main page from main branch)

@mamrezb
Copy link
Copy Markdown
Contributor Author

mamrezb commented Apr 10, 2026

@xirehat The overflow in the deploy preview is coming from the legacy kubeweekly form in layouts/index.html. But that file doesn't exist on main anymore (it was already deleted). So once dev-1.33-fa.1 merges into main through #55093, the issue resolves on its own regardless of this PR. This PR is just cleanup to remove a dead shortcode call.

@xirehat
Copy link
Copy Markdown
Member

xirehat commented Apr 11, 2026

@mamrezb OK, If you think this PR is ready to be merged, change it to Open state

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/localization General issues or PRs related to localization cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. language/fa Issues or PRs related to Persian language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants