Skip to content

Conversation

@reneeteng
Copy link
Contributor

Added PR links.

@ks-ci-bot
Copy link
Collaborator

Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits.

📝 Please follow instructions in the contributing guide to update your commits with the DCO

Full details of the Developer Certificate of Origin can be found at developercertificate.org.

The list of commits missing DCO signoff:

  • 06c8cbd Update ZH-CN Localization Task.md
Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ks-ci-bot ks-ci-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 31, 2020
@rayzhou2017
Copy link

please sign off your pr by using -s like

git commit -a -s

@LinuxSuRen
Copy link
Contributor

hi @reneeteng , I'm wondering if you can take some time to fix the dco issues.

@LinuxSuRen
Copy link
Contributor

hi @rayzhou2017 and @FeynmanZhou, as we can see here. It's very easy to make some conflicts. Because all people need to update one file. So I'm wondering if we can use an alternative solution to manage these tasks. For example, convert these tasks into issues.

@FeynmanZhou
Copy link

FeynmanZhou commented Dec 29, 2020

hi @rayzhou2017 and @FeynmanZhou, as we can see here. It's very easy to make some conflicts. Because all people need to update one file. So I'm wondering if we can use an alternative solution to manage these tasks. For example, convert these tasks into issues.

Yes. The key point is we have to reminder contributors to sign-off commits in advance. Otherwise, our contributors may still have problems when submitting PR to any repo.

@reneeteng
Copy link
Contributor Author

hi @reneeteng , I'm wondering if you can take some time to fix the dco issues.

Sorry for the late reply. What should I do now?

@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: reneeteng
To complete the pull request process, please assign calvinyv after the PR has been reviewed.
You can assign the PR to them by writing /assign @calvinyv in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@reneeteng
Copy link
Contributor Author

/assign @calvinyv

@calvinyv
Copy link
Member

/lgtm

@ks-ci-bot ks-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 19, 2021
@LinuxSuRen
Copy link
Contributor

LinuxSuRen commented Aug 16, 2021

Any updates?

/cc @kubesphere/sig-docs

@FeynmanZhou
Copy link

/lgtm
/approve

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dco-signoff: no lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants