Incorporate changes for restic standalone pkg#77
Merged
anisurrahman75 merged 4 commits intomasterfrom Feb 16, 2026
Merged
Conversation
Signed-off-by: Arnab Baishnab Nipun <nipun@appscode.com>
There was a problem hiding this comment.
Pull request overview
This PR vendors and switches the CLI to use the new standalone gomodules.xyz/restic package instead of kubestash.dev/apimachinery/pkg/restic, aiming to support “restic standalone pkg” integration.
Changes:
- Added vendored
gomodules.xyz/resticmodule and updatedgo.mod/go.sum/vendor/modules.txt. - Updated CLI commands to import
gomodules.xyz/resticand adjusted setup to pass encryption secrets as*core.Secret. - Added a helper to fetch the encryption secret from the cluster.
Reviewed changes
Copilot reviewed 8 out of 28 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
go.mod / go.sum |
Adds dependency on gomodules.xyz/restic and updates module sums. |
vendor/modules.txt |
Vendors gomodules.xyz/restic with explicit Go version info. |
vendor/gomodules.xyz/restic/* |
Introduces the standalone restic wrapper implementation (commands, backend config, env setup, locking helpers, etc.). |
pkg/view.go |
Switches restic import and updates wrapper setup for manifest viewing. |
pkg/download.go |
Switches restic import and updates wrapper setup for snapshot download. |
pkg/restore.go |
Switches restic import and updates wrapper setup for manifest restore flow. |
pkg/unlock.go |
Switches restic import and updates wrapper setup for unlock flow. |
pkg/add_key.go |
Switches restic import and updates wrapper setup for restic key management. |
pkg/common/types.go |
Updates restic types in shared options to the new module. |
pkg/util.go |
Adds getEncryptionSecret helper for retrieving core.Secret. |
Comments suppressed due to low confidence (1)
pkg/add_key.go:146
gomodules.xyz/resticrequiresBackend.ConfigResolver(plus storage credentials inStorageSecret) to be present during wrapper configuration. The backend created here lacks those fields, soNewResticWrapperwill fail before running the docker restic command. Add a resolver that loads the referenced BackupStorage + secret data into the backend.
setupOptions := &restic.SetupOptions{
Backends: []*restic.Backend{
{
Repository: opt.repo.Name,
EncryptionSecret: encryptSecret,
},
},
ScratchDir: ScratchDir,
}
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Arnab Baishnab Nipun <nipun@appscode.com>
anisurrahman75
requested changes
Feb 16, 2026
Signed-off-by: Arnab Baishnab Nipun <nipun@appscode.com>
Signed-off-by: Arnab Baishnab Nipun <nipun@appscode.com>
anisurrahman75
approved these changes
Feb 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.