fix: resolve Auto-QA demo data coverage gaps in cards and detection logic#3792
fix: resolve Auto-QA demo data coverage gaps in cards and detection logic#3792
Conversation
✅ Deploy Preview for kubestellarconsole ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
👋 Hey @Copilot — thanks for opening this PR!
This is an automated message. |
- Update auto-qa.yml EXCLUDE_PATTERN to skip pure UI sub-components (PremiumGauge, HorseshoeGauge, PortalTooltip, AlertListItem) - Update Skeleton check to recognize useReportCardDataState - Update INVENTORY check to recognize useDemoMode/isDemoMode - Update stat block check to recognize useClusters/useMCP - Return isDemoData from useCrioStatus + useLimaStatus hooks - Use isDemoData in CrioStatus.tsx and LimaStatus.tsx to hide stale timestamps when showing demo data - Add useCardDemoState to DynamicCard.tsx for proper demo reporting Signed-off-by: GitHub Copilot <copilot@github.com> Agent-Logs-Url: https://github.com/kubestellar/console/sessions/fd7c830d-a6ee-4fd2-81ce-baf662af09ca Co-authored-by: clubanderson <407614+clubanderson@users.noreply.github.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits. 📝 Please follow instructions in the contributing guide to update your commits with the DCO Full details of the Developer Certificate of Origin can be found at developercertificate.org. The list of commits missing DCO signoff:
DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Auto-QA flagged several cards as missing demo data support. Some were genuine gaps (
CrioStatus,LimaStatus,DynamicCard); others were false positives — the detection patterns didn't cover all valid demo-awareness patterns used in this codebase.Auto-QA Detection Fixes (
auto-qa.yml)PremiumGauge,HorseshoeGauge,PortalTooltip,AlertListItem— pure UI sub-components with no data fetching; parent cards own demo modeuseReportCardDataStateas a valid pattern; llmd cards (LatencyBreakdown,ParetoFrontier, etc.) correctly delegate skeleton rendering toCardWrappervia this hookuseDemoMode/isDemoMode—OpenFeatureStatusalready uses theseuseClusters/useMCP— MCP-backed hooks providing live cluster dataCrioStatus + LimaStatus
Returned
isDemoDatafrom both hooks and used it in the component to suppress the stale "last check time" timestamp during demo mode — a meaningless field when data is fabricated.DynamicCard
Added
useCardDemoState({ requires: 'agent' })+useReportCardDataStatesoCardWrappercorrectly shows the Demo badge when no agent is connected. Dynamic cards can't provide their own demo data, but they should at least surface the demo indicator.Changes Made
auto-qa.ymlEXCLUDE_PATTERN and demo detection patterns to eliminate false positivesuseCrioStatus/useLimaStatusto exposeisDemoDatain their return typeCrioStatus.tsx/LimaStatus.tsxto useisDemoData(hide stale timestamps in demo mode)DynamicCard.tsxviauseCardDemoState+useReportCardDataStateChecklist
git commit -s)👀 Reviewer Notes
The auto-qa.yml changes are the most impactful: they prevent recurring false-positive noise from sub-components and cards using alternate (but valid) demo-awareness patterns. The component changes are minimal and behaviorally additive only.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.