Fix auto-QA error handling: ErrorBoundary wrapping + console.error cleanup#3802
Fix auto-QA error handling: ErrorBoundary wrapping + console.error cleanup#3802clubanderson merged 2 commits intomainfrom
Conversation
✅ Deploy Preview for kubestellarconsole ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
👋 Hey @Copilot — thanks for opening this PR!
This is an automated message. |
…r cleanup Signed-off-by: GitHub Copilot <copilot@github.com> Agent-Logs-Url: https://github.com/kubestellar/console/sessions/fdf445ac-c467-458a-acdd-254240fe39d9 Co-authored-by: clubanderson <407614+clubanderson@users.noreply.github.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits. 📝 Please follow instructions in the contributing guide to update your commits with the DCO Full details of the Developer Certificate of Origin can be found at developercertificate.org. The list of commits missing DCO signoff:
DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
Thank you for your contribution! Your PR has been merged. Check out what's new:
Stay connected: Slack #kubestellar-dev | Multi-Cluster Survey |
Auto-QA flagged 10 complex cards missing
ErrorBoundary, 15console.errorcalls without user-visible feedback, and unsafe WebSocket parse failures swallowed silently.📌 Fixes
📝 Summary of Changes
DynamicCardErrorBoundaryto prevent full-page crashes from isolated render failuresconsole.errorcalls whereshowToast/setErroralready provided user feedbacksaveConfigfailures inNotificationSettingsSectionconsole.errorto silentcatch {}(code already falls back gracefully)Changes Made
ErrorBoundary wrapping (pattern: rename to
XInternal, export wrapper viaDynamicCardErrorBoundary):TopPods,SecurityIssues,ServiceExports,SudokuGame,KubeCraft3D,CrossClusterPolicyComparison,ProactiveGPUNodeHealthMonitor,LatencyBreakdown,ParetoFrontier,EPPRoutingconsole.error cleanup (user feedback already existed):
YAMLDrillDown.tsx—showToastalready presentAlertDetail.tsx—showToastalready presentProfileSection.tsx—setError+ UI display already presentActual fix — missing user feedback added:
NotificationSettingsSection.tsx—saveConfignow returnsboolean;updateConfigcallsshowToaston failure;loadConfigsilently falls back to{}Silent catch for non-critical parse failures:
KustomizationDrillDown.tsx,PodDrillDown.tsx— 12 WebSocketJSON.parsecatch blocks converted tocatch { // Ignore malformed WebSocket messages }Checklist
git commit -s)Screenshots or Logs (if applicable)
N/A — error boundary UI is only visible on render crash; no visual change under normal operation.
👀 Reviewer Notes
All lint errors in modified files are pre-existing (confirmed via
git stashbaseline check). No new lint errors introduced. TheDynamicCardErrorBoundarywrapper pattern matchesServiceImports.tsxand other existing wrapped cards.💬 Send tasks to Copilot coding agent from Slack and Teams to turn conversations into code. Copilot posts an update in your thread when it's finished.