e2e: add building blocks and test agent mode #73
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tupyy
force-pushed
the
e2e-followup-1
branch
6 times, most recently
from
76fd4f0 to
48173a7
Compare
AvielSegev
reviewed
Feb 2, 2026
test/e2e/actioner.go
Outdated
| Name string `json:"name"` | ||
| } | ||
|
|
||
| func (a *Actioner) CreateSource(name string) (string, error) { |
Collaborator
There was a problem hiding this comment.
https://github.com/kubev2v/migration-planner/blob/main/test/e2e/service/source.go#L19
Can we reuse the code from the planner?
I mean moving part of the files from test/e2e into pkg and then use them in both places?
Collaborator
Author
There was a problem hiding this comment.
right. I've forgotten about that one. We don't need to move it to pkg. I'll try to use it.
AvielSegev
reviewed
Feb 3, 2026
| ) | ||
|
|
||
| BeforeAll(func() { | ||
| var err error |
Collaborator
There was a problem hiding this comment.
any reason for not putting it in the var group above?
tupyy
force-pushed
the
e2e-followup-1
branch
9 times, most recently
from
69e66f9 to
dd29a92
Compare
add building blocks for tests: - proxy which acts as a reverse proxy between agent and backend - observer to count the requests between agent and backend - actioner to act as a user on backend or to create jwt for agent - dbReadWriter to act directly on the db to check or create resources like private keys for agent authentication Signed-off-by: Cosmin Tupangiu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Cosmin Tupangiu [email protected]