MTV-3649 Transfer network setting test automation #2164

Pedro-S-Abreu · 2025-12-19T19:04:45Z

📝 Links

https://issues.redhat.com/browse/MTV-3649

📝 Description

Transfer network setting test automation

#2178 should be merged before this.

🎥 Demo

📝 CC://

codecov-commenter · 2025-12-19T19:07:52Z

⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 14.09%. Comparing base (13484d0) to head (989001f).
⚠️ Report is 940 commits behind head on main.

Files with missing lines	Patch %	Lines
...w/tabs/Settings/components/SettingsSelectInput.tsx	0.00%	4 Missing ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@             Coverage Diff             @@
##             main    #2164       +/-   ##
===========================================
- Coverage   36.81%   14.09%   -22.72%     
===========================================
  Files         158     1031      +873     
  Lines        2548    19101    +16553     
  Branches      599     3902     +3303     
===========================================
+ Hits          938     2692     +1754     
- Misses       1428    15766    +14338     
- Partials      182      643      +461

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Pedro-S-Abreu · 2026-01-08T15:27:18Z

/retest

Pedro-S-Abreu · 2026-01-09T17:03:55Z

/retest

testing/playwright/e2e/downstream/create-provider.spec.ts

avivtur · 2026-01-12T14:06:52Z

testing/playwright/utils/resource-manager/ResourceManager.ts

+    nad: V1NetworkAttachmentDefinition,
+    namespace: string,
+  ): Promise<V1NetworkAttachmentDefinition | null> {
+    return createNad(page, nad as Parameters<typeof createNad>[1], namespace);


creating a function that calls a function with the same name looks a bit redundant to me why not using the inner createNad directly

avivtur · 2026-01-12T14:09:26Z

testing/playwright/utils/resource-manager/ResourceManager.ts

+/**
+ * NetworkAttachmentDefinition type for CNI network configuration
+ */
+export type V1NetworkAttachmentDefinition = {


I already saw this definition, why twice?

avivtur · 2026-01-12T14:13:31Z

testing/playwright/fixtures/helpers/resourceCreationHelpers.ts

  testData: ReturnType<typeof createPlanTestData>;
 };

+export type TestNad = V1NetworkAttachmentDefinition & {


can't use V1NetworkAttachmentDefinition directly?

if we can use it directly please remove this type

- Update CreateProviderPage selectors for new form structure - Add provider-specific field methods (vSphere, OVA, OVirt) - Parametrize provider creation tests using test scenarios - Update StorageMapStep to correctly parse source storage column - Update test data for current environment Resolves: MTV-3741 Signed-off-by: Pedro Abreu <pabreu@redhat.com>

Resolves: MTV-3649 Signed-off-by: Pedro Abreu <pabreu@redhat.com>

avivtur · 2026-01-14T10:03:37Z

testing/playwright/e2e/downstream/providers/create-provider.spec.ts

+            if (testProviderData.useVddkAioOptimization === true) {
              expect(providerResource?.spec?.settings?.useVddkAioOptimization).toBe('true');
-            }
-            if (!testProviderData.useVddkAioOptimization) {
+            } else if (testProviderData.useVddkAioOptimization === false) {


no need for explicit check for boolean and can remove else:
if (testProviderData.useVddkAioOptimization) {
expect(providerResource?.spec?.settings?.useVddkAioOptimization).toBe('true');
} if (!testProviderData.useVddkAioOptimization) { ...

avivtur · 2026-01-14T10:04:09Z

testing/playwright/fixtures/helpers/resourceCreationHelpers.ts

  testData: ReturnType<typeof createPlanTestData>;
 };

+export type TestNad = V1NetworkAttachmentDefinition & {


if we can use it directly please remove this type

Resolves: None Signed-off-by: Pedro Abreu <pabreu@redhat.com>

…n in createTestNad function Resolves: None Signed-off-by: Pedro Abreu <pabreu@redhat.com>

sonarqubecloud · 2026-01-14T17:31:02Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

avivtur · 2026-01-14T18:45:50Z

LGTM

Pedro-S-Abreu changed the title ~~[WIP] MTV-3649 Transfer network steeing test automation~~ [WIP] MTV-3649 Transfer network setting test automation Dec 22, 2025

Pedro-S-Abreu force-pushed the transfer-network-test branch from 39f61f3 to 433e5fa Compare December 23, 2025 20:20

Pedro-S-Abreu force-pushed the transfer-network-test branch from 433e5fa to d01c5f6 Compare January 7, 2026 14:47

Pedro-S-Abreu changed the title ~~[WIP] MTV-3649 Transfer network setting test automation~~ MTV-3649 Transfer network setting test automation Jan 8, 2026

Pedro-S-Abreu marked this pull request as ready for review January 8, 2026 01:56

avivtur force-pushed the transfer-network-test branch from fd2ef68 to d8e79d4 Compare January 11, 2026 09:49

avivtur reviewed Jan 12, 2026

View reviewed changes

testing/playwright/e2e/downstream/create-provider.spec.ts Outdated Show resolved Hide resolved

avivtur reviewed Jan 12, 2026

View reviewed changes

testing/playwright/e2e/downstream/create-provider.spec.ts Outdated Show resolved Hide resolved

avivtur reviewed Jan 12, 2026

View reviewed changes

Pedro-S-Abreu added 7 commits January 12, 2026 13:34

test for controller transfer network

d5089c9

Resolves: MTV-3649 Signed-off-by: Pedro Abreu <pabreu@redhat.com>

Refactor resource management API calls to use a generic helper method

2a10639

Resolves: MTV-3649 Signed-off-by: Pedro Abreu <pabreu@redhat.com>

cleanup

22dc8f4

Resolves: MTV-3649 Signed-off-by: Pedro Abreu <pabreu@redhat.com>

Remove unused helper files for NAD and Network Map

205f592

Resolves: MTV-3649 Signed-off-by: Pedro Abreu <pabreu@redhat.com>

remove unused methods

dc7f23f

Resolves: MTV-3649 Signed-off-by: Pedro Abreu <pabreu@redhat.com>

restore addNetworkMap method

cd560c0

Resolves: MTV-3649 Signed-off-by: Pedro Abreu <pabreu@redhat.com>

Pedro-S-Abreu force-pushed the transfer-network-test branch from d8e79d4 to cd560c0 Compare January 12, 2026 19:09

Pedro-S-Abreu requested a review from avivtur January 12, 2026 19:16

Pedro-S-Abreu added 2 commits January 12, 2026 14:54

Refactor resource creation helpers t

dc3c0af

Resolves: MTV-3649 Signed-off-by: Pedro Abreu <pabreu@redhat.com>

Refactor export of V1NetworkAttachmentDefinition

7808d55

Resolves: MTV-3649 Signed-off-by: Pedro Abreu <pabreu@redhat.com>

avivtur reviewed Jan 14, 2026

View reviewed changes

Pedro-S-Abreu added 2 commits January 14, 2026 12:11

Refactor provider creation test conditions

8cb3afa

Resolves: None Signed-off-by: Pedro Abreu <pabreu@redhat.com>

Refactor TestNad type to directly return V1NetworkAttachmentDefinitio…

989001f

…n in createTestNad function Resolves: None Signed-off-by: Pedro Abreu <pabreu@redhat.com>

Pedro-S-Abreu requested a review from avivtur January 14, 2026 17:30

avivtur added this pull request to the merge queue Jan 14, 2026

Merged via the queue into kubev2v:main with commit 7a873ce Jan 14, 2026
10 checks passed

MTV-3649 Transfer network setting test automation #2164

MTV-3649 Transfer network setting test automation #2164

Uh oh!

Conversation

Pedro-S-Abreu commented Dec 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📝 Links

📝 Description

🎥 Demo

📝 CC://

Uh oh!

codecov-commenter commented Dec 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Pedro-S-Abreu commented Jan 8, 2026

Uh oh!

Pedro-S-Abreu commented Jan 9, 2026

Uh oh!

Uh oh!

Uh oh!

avivtur Jan 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

avivtur Jan 12, 2026

Choose a reason for hiding this comment

Uh oh!

avivtur Jan 12, 2026

Choose a reason for hiding this comment

Uh oh!

avivtur Jan 14, 2026

Choose a reason for hiding this comment

Uh oh!

avivtur Jan 14, 2026

Choose a reason for hiding this comment

Uh oh!

avivtur Jan 14, 2026

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud bot commented Jan 14, 2026

Quality Gate passed

Uh oh!

avivtur commented Jan 14, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Pedro-S-Abreu commented Dec 19, 2025 •

edited

Loading

codecov-commenter commented Dec 19, 2025 •

edited

Loading

avivtur Jan 12, 2026 •

edited

Loading