Resolves: MTV-3380 | Allow setting converter pod label, node selectors and affinities by avivtur · Pull Request #2260 · kubev2v/forklift-console-plugin

avivtur · 2026-02-12T10:32:00Z

📝 Links

https://issues.redhat.com/browse/MTV-3380

📝 Description

Adding settings under plan details for converterLabels, converterNodeSelectors and converterAffinities

🎥 Demo

Screen.Recording.2026-02-12.at.12.26.34.mov

📝 CC://

codecov-commenter · 2026-02-12T10:34:08Z

⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 0% with 95 lines in your changes missing coverage. Please review.
✅ Project coverage is 14.87%. Comparing base (13484d0) to head (eda550d).
⚠️ Report is 986 commits behind head on main.

Files with missing lines	Patch %	Lines
...rNodeSelector/ConvertorNodeSelectorDetailsItem.tsx	0.00%	24 Missing and 1 partial ⚠️
...nts/ConvertorLabels/ConvertorLabelsDetailsItem.tsx	0.00%	22 Missing and 1 partial ⚠️
...ConvertorAffinity/ConvertorAffinityDetailsItem.tsx	0.00%	21 Missing and 1 partial ⚠️
.../components/SettingsSection/utils/patchPlanSpec.ts	0.00%	7 Missing ⚠️
...rgetNodeSelector/TargetNodeSelectorDetailsItem.tsx	0.00%	5 Missing ⚠️
...nents/TargetAffinity/TargetAffinityDetailsItem.tsx	0.00%	4 Missing ⚠️
...omponents/TargetLabels/TargetLabelsDetailsItem.tsx	0.00%	4 Missing ⚠️
...ils/components/SettingsSection/SettingsSection.tsx	0.00%	3 Missing ⚠️
...mponents/AffinityModal/utils/affinityToRowsData.ts	0.00%	1 Missing ⚠️
...tyViewDetailsItemContent/utils/getAffinityRules.ts	0.00%	1 Missing ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@             Coverage Diff             @@
##             main    #2260       +/-   ##
===========================================
- Coverage   36.81%   14.87%   -21.95%     
===========================================
  Files         158     1136      +978     
  Lines        2548    20253    +17705     
  Branches      599     3988     +3389     
===========================================
+ Hits          938     3012     +2074     
- Misses       1428    16578    +15150     
- Partials      182      663      +481

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Pedro-S-Abreu · 2026-02-12T16:31:23Z

testing/playwright/e2e/downstream/plans/plan-convertor-scheduling.spec.ts

Tests look good! I recommend breaking tests into test.step( blocks.

avivtur · 2026-02-12T19:07:20Z

/retest

Pedro-S-Abreu · 2026-02-13T18:47:08Z

testing/playwright/page-objects/PlanDetailsPage/modals/ConvertorAffinityModal.ts

This is almost identical to TargetAffinityModal.ts, consider creating a shared base class.

Pedro-S-Abreu · 2026-02-13T18:47:50Z

testing/playwright/page-objects/PlanDetailsPage/modals/ConvertorLabelsModal.ts

almost identical to TargetLabelsModal.ts

Pedro-S-Abreu · 2026-02-13T18:48:30Z

testing/playwright/page-objects/PlanDetailsPage/modals/ConvertorNodeSelectorModal.ts

almost identical to TargetNodeSelectorModal.ts

Pedro-S-Abreu · 2026-02-13T18:54:06Z

testing/playwright/page-objects/PlanDetailsPage/tabs/DetailsTab.ts

Consider reusing or generalizing the existing Target Node methods instead of creating identical Convertor copies

src/components/AffinityModal/AffinityModal.tsx

src/components/AffinityViewDetailsItemContent/utils/getAffinityRules.ts

src/plans/details/tabs/Details/components/SettingsSection/utils/patchPlanSpec.ts

...onents/SettingsSection/components/ConvertorNodeSelector/ConvertorNodeSelectorDetailsItem.tsx

jpuzz0 · 2026-02-18T21:03:34Z

testing/playwright/page-objects/PlanDetailsPage/tabs/DetailsTab.ts

+    testId: string,
+    modal: { waitForModalToOpen: () => Promise<void> },
+  ): Promise<void> {
+    await this.page.getByTestId(testId).locator('button').click();


Nice refactor consolidating these into a shared helper. .locator('button').click() grabs the first button inside the test-id container — if a detail item ever has multiple buttons (e.g., help popover + edit), this could click the wrong one. Is there a more specific selector for the edit button?

this should be in a different PR, @Pedro-S-Abreu can we open a ticket for this improvment?

jpuzz0 · 2026-02-18T21:03:34Z

testing/playwright/e2e/downstream/plans/plan-convertor-scheduling.spec.ts

+  const { name: planName, namespace } = testPlan.metadata;
+  await planDetailsPage.navigate(planName, namespace);
+  await planDetailsPage.verifyPlanTitle(planName);
+  return { planDetailsPage, planName, namespace, testData: testPlan.testData };


Nit: namespace and testData are returned here but never destructured in any of the test calls (lines 27, 73, 132). Could simplify the return to just { planDetailsPage, planName }.

planName is also redundant, changed

avivtur · 2026-02-19T17:22:46Z

/retest

…s and affinities Signed-off-by: Aviv Turgeman <aturgema@redhat.com>

Signed-off-by: Aviv Turgeman <aturgema@redhat.com>

sonarqubecloud · 2026-02-19T19:32:18Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
9.2% Duplication on New Code

See analysis details on SonarQube Cloud

jpuzz0

2 optional nit comment. LGTM

jpuzz0 · 2026-02-19T20:33:00Z

...s/Details/components/SettingsSection/components/TargetAffinity/TargetAffinityDetailsItem.tsx

+      content={
+        <AffinityViewDetailsItemContent
+          affinity={plan?.spec?.targetAffinity as K8sIoApiCoreV1Affinity}
+        />


nit: I think you can store plan?.spec?.targetAffinity as K8sIoApiCoreV1Affinity as a variable so you don't have to cast twice

jpuzz0 · 2026-02-19T20:33:01Z

...ils/components/SettingsSection/components/ConvertorAffinity/ConvertorAffinityDetailsItem.tsx

@@ -0,0 +1,63 @@
+import type { FC } from 'react';
+import { isPlanEditable } from 'src/plans/details/components/PlanStatus/utils/utils';


Nit: partially addressed from previous review — @components/* and @utils/* aliases are now used, but isPlanEditable still imports via 'src/plans/...' path. Consistent with the sibling target components though, so more of a future cleanup note.

Pedro-S-Abreu reviewed Feb 12, 2026

View reviewed changes

Pedro-S-Abreu reviewed Feb 13, 2026

View reviewed changes

avivtur force-pushed the feature/MTV-3380-importer-pod-scheduling branch 6 times, most recently from 9454977 to 46c2b71 Compare February 18, 2026 13:12

jpuzz0 reviewed Feb 18, 2026

View reviewed changes

avivtur force-pushed the feature/MTV-3380-importer-pod-scheduling branch 2 times, most recently from 1d2eea3 to ad54fcf Compare February 19, 2026 13:13

avivtur added 2 commits February 19, 2026 21:31

Resolves: MTV-3380 | Allow setting converter pod label, node selector…

22e9110

…s and affinities Signed-off-by: Aviv Turgeman <aturgema@redhat.com>

Resolves: MTV-3380 | fix comment from jpuzz0

eda550d

Signed-off-by: Aviv Turgeman <aturgema@redhat.com>

avivtur force-pushed the feature/MTV-3380-importer-pod-scheduling branch from 0d90717 to eda550d Compare February 19, 2026 19:31

jpuzz0 approved these changes Feb 19, 2026

View reviewed changes

		@@ -0,0 +1,63 @@
		import type { FC } from 'react';
		import { isPlanEditable } from 'src/plans/details/components/PlanStatus/utils/utils';

Comments

Conversation

avivtur commented Feb 12, 2026

📝 Links

📝 Description

🎥 Demo

📝 CC://

Uh oh!

codecov-commenter commented Feb 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Choose a reason for hiding this comment

Uh oh!

avivtur commented Feb 12, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Pedro-S-Abreu Feb 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Pedro-S-Abreu Feb 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Pedro-S-Abreu Feb 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

avivtur commented Feb 19, 2026

Uh oh!

sonarqubecloud bot commented Feb 19, 2026

Quality Gate passed

Uh oh!

jpuzz0 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

codecov-commenter commented Feb 12, 2026 •

edited

Loading

Pedro-S-Abreu Feb 13, 2026 •

edited

Loading

Pedro-S-Abreu Feb 13, 2026 •

edited

Loading

Pedro-S-Abreu Feb 13, 2026 •

edited

Loading