chore(makefile): enhance make help with env vars, quick start, and project info#5605
chore(makefile): enhance make help with env vars, quick start, and project info#5605yaacov merged 1 commit intokubev2v:mainfrom
Conversation
yaacov
requested review from
Hazanel,
mnecas,
mrnold and
solenoci
as code owners
|
@solenoci please review |
Makefile
Outdated
| @echo " - Upstream deployment: operator/streams/upstream/upstream_manifests" | ||
| @echo " - Downstream deployment: operator/streams/downstream/downstream_manifests" |
There was a problem hiding this comment.
can you please update this to operator/.downstream_manifests and same for upstream?
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5605 +/- ##
==========================================
- Coverage 15.45% 10.02% -5.43%
==========================================
Files 112 500 +388
Lines 23377 57360 +33983
==========================================
+ Hits 3613 5751 +2138
- Misses 19479 51122 +31643
- Partials 285 487 +202
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
do not ignore generated dot manifests, they must be included in vcs. Please revert changes to this file.
There was a problem hiding this comment.
not ignoring the manifests, removed the now skipped stream manifests
yaacov
force-pushed
the
update-makefile
branch
2 times, most recently
from
20e1924 to
f80bf14
Compare
…oject info Expand the help target to surface key environment variables, a quick start section, and a one-line project description so new contributors can get oriented without reading the source. Remove the unused kustomized-manifests target and rewire update-manifests to chain generate, manifests, and generate-manifests into a single entry point. Resolves: none Signed-off-by: yaacov <yzamir@redhat.com>
|
3 participants
Expand the help target to surface key environment variables, a quick start section, and a one-line project description so new contributors can get oriented without reading the source.
Remove the unused kustomized-manifests target and rewire update-manifests to chain generate, manifests, and generate-manifests into a single entry point.
Resolves: none