MTV-4826 | Fix NetApp Shift NPE with Storage Offload validation#5621
Merged
mnecas merged 1 commit intokubev2v:mainfrom Mar 25, 2026
Merged
MTV-4826 | Fix NetApp Shift NPE with Storage Offload validation#5621mnecas merged 1 commit intokubev2v:mainfrom
mnecas merged 1 commit intokubev2v:mainfrom
Conversation
Resolves: MTV-4826 Issue: Becuase in MTV 2.11.0 the storage offload is enabled by default, we perform validation to check if offload is enabled on all plans. However this validation had NPE if the storage map is not definied. Fix: Add validation to check for nil map. Signed-off-by: Martin Necas <mnecas@redhat.com>
mnecas
requested review from
Hazanel,
mrnold,
solenoci and
yaacov
as code owners
|
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5621 +/- ##
==========================================
- Coverage 15.45% 10.10% -5.35%
==========================================
Files 112 500 +388
Lines 23377 57431 +34054
==========================================
+ Hits 3613 5804 +2191
- Misses 19479 51146 +31667
- Partials 285 481 +196
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Hazanel
approved these changes
Mar 25, 2026
mnecas
added
the
backport-release-2.11
Member
Author
|
/backport release-2.11 |
|
✅ PR #5621 backported to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: MTV-4826
Issue:
Becuase in MTV 2.11.0 the storage offload is enabled by default, we perform validation to check if offload is enabled on all plans. However this validation had NPE if the storage map is not definied.
Fix:
Add validation to check for nil map.