MTV-3663 | AAP job template hooks for migration plans#5622
Draft
gwencasey96 wants to merge 2 commits intokubev2v:mainfrom
Draft
MTV-3663 | AAP job template hooks for migration plans#5622gwencasey96 wants to merge 2 commits intokubev2v:mainfrom
gwencasey96 wants to merge 2 commits intokubev2v:mainfrom
Conversation
gwencasey96
requested review from
Hazanel,
mnecas,
mrnold,
solenoci and
yaacov
as code owners
Add optional spec.aap on Hook (url, jobTemplateId, tokenSecret, timeout). Controller launches AAP job templates with migration extra_vars and waits for completion; token read from Secret. Regenerate CRD and operator manifests. Make spec.image optional with CEL: either spec.aap or non-empty image and playbook for local hooks. Hook and plan controllers validate execution mode. Use package logger in AAP client poll loop. Replace ginkgo hook tests with testing.T to avoid running the entire plan package suite from TestHook; align ServiceAccount template tests with current template() behavior. Ref: https://issues.redhat.com/browse/MTV-3663 Resolves: MTV-3663 Made-with: Cursor Signed-off-by: Gwen Casey <gcasey@redhat.com>
gwencasey96
force-pushed
the
ansible-integration-change-crdr
branch
from
12d46da to
54c791b
Compare
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5622 +/- ##
==========================================
- Coverage 15.45% 10.11% -5.35%
==========================================
Files 112 501 +389
Lines 23377 57645 +34268
==========================================
+ Hits 3613 5828 +2215
- Misses 19479 51333 +31854
- Partials 285 484 +199
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Resolves: MTV-3663 Refresh operator/.upstream_manifests via KUBECTL kustomize + controller-gen output: relatedImages naming (vsphere copy offload), HyperV provider, CLI download, and virt-v2v RHEL9 entries. Made-with: Cursor Signed-off-by: Gwen Casey <gcasey@redhat.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add optional spec.aap on Hook (url, jobTemplateId, tokenSecret, timeout). Controller launches AAP job templates with migration extra_vars and waits for completion; token read from Secret. Regenerate CRD, deepcopy, and operator stream manifests (update-manifests).
Ref: https://issues.redhat.com/browse/MTV-3663
Resolves: MTV-3663
Made-with: Cursor