Skip to content

NO-JIRA | fix: fix failing unit tests#992

Merged
openshift-merge-bot[bot] merged 1 commit intokubev2v:mainfrom
amalimov:hotfix/failing-complexity-unit-test
Mar 15, 2026
Merged

NO-JIRA | fix: fix failing unit tests#992
openshift-merge-bot[bot] merged 1 commit intokubev2v:mainfrom
amalimov:hotfix/failing-complexity-unit-test

Conversation

@amalimov
Copy link
Copy Markdown
Collaborator

@amalimov amalimov commented Mar 15, 2026

unit tests were not aligned with the new complexity scores

Summary by CodeRabbit

  • Tests
    • Updated OS complexity scoring expectations for CentOS 7 (64-bit) and FreeBSD (64-bit) in test suites; OS classification refinement applied.

unit tests were not aligned with the new complexity scores

Signed-off-by: Ami Malimovka <amalimov@redhat.com>
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 15, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 00b8dd58-d3f3-4e9f-94a9-88be7634dd3f

📥 Commits

Reviewing files that changed from the base of the PR and between a1f1b26 and caf42bd.

📒 Files selected for processing (3)
  • internal/handlers/v1alpha1/estimation_test.go
  • internal/service/estimation_test.go
  • pkg/estimations/complexity/complexity_test.go

📝 Walkthrough

Walkthrough

This PR updates test expectations for OS complexity scoring across three test files. CentOS 7 (64-bit) complexity score changes from 2 to 1, FreeBSD (64-bit) changes from 0 to 3, and one OS name is updated from VMware Photon OS to Other Linux in tests.

Changes

Cohort / File(s) Summary
OS Complexity Scoring Tests
internal/handlers/v1alpha1/estimation_test.go, internal/service/estimation_test.go, pkg/estimations/complexity/complexity_test.go
Updated complexity score expectations for CentOS 7 (64-bit) from 2→1 and FreeBSD (64-bit) from 0→3. Renamed VMware Photon OS (64-bit) to Other Linux (64-bit) in test assertions.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

Suggested labels

lgtm, approved

Suggested reviewers

  • machacekondra
  • Jos-Jerus

Poem

🐰 Complexity scores now ring true,
CentOS lighter, FreeBSD bold and new,
Tests dance with precision's delight,
OS classifiers shining bright!

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: fixing failing unit tests by updating test expectations to align with new complexity scores.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ronenav
Copy link
Copy Markdown
Collaborator

ronenav commented Mar 15, 2026

/lgtm

@Jos-Jerus
Copy link
Copy Markdown
Collaborator

/approve

@ronenav
Copy link
Copy Markdown
Collaborator

ronenav commented Mar 15, 2026

/approve

@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented Mar 15, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Jos-Jerus, ronenav

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 8e37a2d into kubev2v:main Mar 15, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants