Conversation
Signed-off-by: MdSahil-oss <Mohdssahil1@gmail.com>
Signed-off-by: MdSahil-oss <Mohdssahil1@gmail.com>
Signed-off-by: MdSahil-oss <Mohdssahil1@gmail.com>
Signed-off-by: MdSahil-oss <Mohdssahil1@gmail.com>
Signed-off-by: MdSahil-oss <Mohdssahil1@gmail.com>
mdsahiloss
requested review from
barnettZQG,
wangyikewxgm and
wonderflow
as code owners
Signed-off-by: MdSahil-oss <Mohdssahil1@gmail.com>
Signed-off-by: MdSahil-oss <Mohdssahil1@gmail.com>
Signed-off-by: MdSahil-oss <Mohdssahil1@gmail.com>
Signed-off-by: MdSahil-oss <Mohdssahil1@gmail.com>
Signed-off-by: MdSahil-oss <Mohdssahil1@gmail.com>
Signed-off-by: MdSahil-oss <Mohdssahil1@gmail.com>
Signed-off-by: MdSahil-oss <Mohdssahil1@gmail.com>
Signed-off-by: MdSahil-oss <Mohdssahil1@gmail.com>
|
@wonderflow @wangyikewxgm Please review this addon :) |
| **Minio** | ||
|
|
||
| ```shell | ||
| helm install minio \ |
There was a problem hiding this comment.
- can we use vela application or leverage addon for this installation?
- the further question is: if I were the user, I have already learned
helm install, why I don't use helm install to install hive?
There was a problem hiding this comment.
Extended addon capabililty to install dependencies at the time of addon installation.
There was a problem hiding this comment.
Sorry but I don't think this conversation is resolved, yet. What @wonderflow means is this addon needs to have its distinct advantages that will benfit users compared to helm, otherwise the user would chose helm instead. Not just on the first hands-on, but also on subsequent deployments. I don't have a good knowledge about Hive, but here are some possible improvements, which are just my thoughts on this particular issue.
For example, vela Definitions provide an easy way to spin up complex things. In this particular addon, you have 3 components hive-cluster, s3-connection and secret-class that must be applied in order to have a functional hive cluster. Can this process be simplified? For example, can the user spin up a hive cluster with just one well-designed component? That well-designed component creates several resources under the hood, abstracts away tedious details from user while maintaining a certain level of customizability. And this is what makes vela or vela addons apart from typical helm installation.
There was a problem hiding this comment.
Thanks @charlie0129 for explanation. And it makes sence to have a simplified installation process. I think I should create a new component that create all hive related resources at once and make hive-cluster running in the cluster.
| hive-postgres-cluster-metastore-default 1/1 76s | ||
| ``` | ||
|
|
||
| For more visit on the website https://docs.stackable.tech/home/stable/hive/index.html. |
There was a problem hiding this comment.
please provide some information here about how to use the hive cluster.
Signed-off-by: MdSahil-oss <Mohdssahil1@gmail.com>
Signed-off-by: MdSahil-oss <Mohdssahil1@gmail.com>
| port: 9000 | ||
| accessStyle: Path | ||
| credentials: | ||
| secretClass: hive-s3-secret-class |
There was a problem hiding this comment.
Why not put all these (including the single-component Applications below) into one single Application that the user can run and test? If used in this way, it is essentially the same as applying a bunch of yamls. The benfit of vela applications are gone.
| ``` | ||
|
|
||
| ```shell | ||
| $ vela ls -A | grep hive |
| properties: { | ||
| repoType: "helm" | ||
| url: "https://charts.min.io/" | ||
| chart: "minio" |
There was a problem hiding this comment.
Is minio mandatory? If not, I don't think minio should be baked in by default. If this is not a mandatory component, then let the user decide whether they need it. For example, use addon parameters to let them customize or provide installation instructions for minio in readme for quick starts.
|
I'm closing this PR here because hive-operator gives an error on runnning, I'll open this PR when would be fixed. |
|
You can draft this pr, actually, without closing it. |
3 participants
Description of your changes
Fixes kubevela/kubevela#5133
How has this code been tested?
Checklist
I have:
[Addon],[example]or[Doc]).versioninmetadata.yamlto generate a new version.Verified Addon promotion rules
If this pr wants to promote an experimental addon to verified, you must check whether meet these conditions too:
metadata.yaml.README.md.