Conversation
Signed-off-by: MdSahil-oss <Mohdssahil1@gmail.com>
Signed-off-by: MdSahil-oss <Mohdssahil1@gmail.com>
Signed-off-by: MdSahil-oss <Mohdssahil1@gmail.com>
Signed-off-by: MdSahil-oss <Mohdssahil1@gmail.com>
Signed-off-by: MdSahil-oss <Mohdssahil1@gmail.com>
Signed-off-by: MdSahil-oss <Mohdssahil1@gmail.com>
Signed-off-by: MdSahil-oss <Mohdssahil1@gmail.com>
Signed-off-by: MdSahil-oss <Mohdssahil1@gmail.com>
Signed-off-by: MdSahil-oss <Mohdssahil1@gmail.com>
Signed-off-by: MdSahil-oss <Mohdssahil1@gmail.com>
Signed-off-by: MdSahil-oss <Mohdssahil1@gmail.com>
Signed-off-by: MdSahil-oss <Mohdssahil1@gmail.com>
Signed-off-by: MdSahil-oss <Mohdssahil1@gmail.com>
|
@wonderflow I've updated postgres addon, I hope now you will be able to run Bytebase with postgres addon :) |
Signed-off-by: MdSahil-oss <Mohdssahil1@gmail.com>
| @@ -0,0 +1,37 @@ | |||
| "postgres-expose": { | |||
There was a problem hiding this comment.
can we reuse the expose trait?
There was a problem hiding this comment.
@wonderflow I've updated postgres-expose trait as expose trait. Please reivew it again.
There was a problem hiding this comment.
why do we need to create a new one instead of using expose trait?
Signed-off-by: MdSahil-oss <Mohdssahil1@gmail.com>
| apiVersion: "v1" | ||
| kind: "Service" | ||
| metadata: annotations: parameter.annotations | ||
| spec: { | ||
| selector: { | ||
| "application": "spilo" | ||
| "cluster-name": "postgres" | ||
| "spilo-role": "master" | ||
| "team": "acid" | ||
| } |
There was a problem hiding this comment.
I had the same concern with @wonderflow . It seems that the existing Expose trait can accomplish the same functionality. Have you considered using it instead
There was a problem hiding this comment.
@wangyikewxgm @wonderflow I tried to do so, But I'm getting an error
could not create cluster: could not create master endpoint: endpoints "postgres" already exists
it seems like expose trait is getting created first then postgres cluster using built in expose trait.
Signed-off-by: MdSahil-oss <Mohdssahil1@gmail.com>
|
@wangyikewxgm @wonderflow I tried to do so, But I'm getting an error it seems like expose trait is getting created first then postgres cluster using built in expose trait. |
|
@MdSahil-oss Hi, does this addon work? We can use postres-expose trait you added instead of built-in expose trait. |
Description of your changes
Update Postgres Addon.
How has this code been tested?
Checklist
I have:
[Addon],[example]or[Doc]).versioninmetadata.yamlto generate a new version.Verified Addon promotion rules
If this pr wants to promote an experimental addon to verified, you must check whether meet these conditions too:
metadata.yaml.README.md.