[Addon] Fix #695 using vela existing addon packaging#714
[Addon] Fix #695 using vela existing addon packaging#714scodeman wants to merge 10 commits intokubevela:masterfrom
Conversation
|
Regarding the failed addon-e2e test.
The chart version seems unfortunately to be linked to the actual addon application tag in github (instead of using appVersion) so I am not sure my PR has to update the chart version, should it ? |
|
Thanks, please refer the failed CI info and fix them. |
d539e91 to
c9335d6
Compare
|
Note that I could not use semver build metadata due to kubernetes/kubernetes#115055 issue |
Hi @wangyikewxgm , @wonderflow, @barnettZQG, @Somefive, done, waiting for your review |
|
ping @Somefive @barnettZQG , please help review, this feature can be useful. |
|
ping @Somefive @barnettZQG , @wangyikewxgm please help review. |
Signed-off-by: florent.madiot.e <florent.madiot.e@thalesdigital.io>
Signed-off-by: florent.madiot.e <florent.madiot.e@thalesdigital.io>
Signed-off-by: florent.madiot.e <florent.madiot.e@thalesdigital.io>
Signed-off-by: florent.madiot.e <florent.madiot.e@thalesdigital.io>
Signed-off-by: florent.madiot.e <florent.madiot.e@thalesdigital.io>
…ue file Signed-off-by: florent.madiot.e <florent.madiot.e@thalesdigital.io>
…s labels not fully supporting semver Signed-off-by: florent.madiot.e <florent.madiot.e@thalesdigital.io>
Signed-off-by: florent.madiot.e <florent.madiot.e@thalesdigital.io>
203c4a2 to
c9c150b
Compare
|
Rebased the MR |
Signed-off-by: florent.madiot.e <florent.madiot.e@thalesdigital.io>
|
Waiting on #783 to be merge to rebase and have dependencies issues resolved |
Description of your changes
As mentionned in #695 the addon chart published by hack/addons/syn_addon_package.go does not generate a proper helm chart with a Chart.yaml in it.
This pull request makes use of the existing vela cli capability to publish addons and that properly covers the generation of the Chart.yaml file as shown in vela source code
github.com/oam-dev/kubevela/pkg/addonpackage that is using the MakeChartCompatible routine. (See https://github.com/kubevela/kubevela/blob/e109d4e525dfc253e861c82901d3947688555d7c/pkg/addon/utils.go#L367)The PR also adds mandatory template.cue where missing and fix invalid (non semver) chart version on
spark-on-k8s-operatorexperimental addonFixes #695
How has this code been tested?
The change has been tested following the github actions:
go mod tidy(cd addons && go run ../hack/addons/syn_addon_package.go ./ https://kubevela.github.io/catalog/official)(cd experimental/addons && go run ../../hack/addons/syn_addon_package.go ./https://kubevela.github.io/catalog/experimental)Checklist
I have:
[Addon],[example]or[Doc]).versioninmetadata.yamlto generate a new version.