Skip to content

[Addon] Fix #695 using vela existing addon packaging#714

Open
scodeman wants to merge 10 commits intokubevela:masterfrom
scodeman:vela_addon_charts
Open

[Addon] Fix #695 using vela existing addon packaging#714
scodeman wants to merge 10 commits intokubevela:masterfrom
scodeman:vela_addon_charts

Conversation

@scodeman
Copy link

@scodeman scodeman commented Aug 2, 2023

Description of your changes

As mentionned in #695 the addon chart published by hack/addons/syn_addon_package.go does not generate a proper helm chart with a Chart.yaml in it.

This pull request makes use of the existing vela cli capability to publish addons and that properly covers the generation of the Chart.yaml file as shown in vela source code github.com/oam-dev/kubevela/pkg/addon package that is using the MakeChartCompatible routine. (See https://github.com/kubevela/kubevela/blob/e109d4e525dfc253e861c82901d3947688555d7c/pkg/addon/utils.go#L367)

The PR also adds mandatory template.cue where missing and fix invalid (non semver) chart version on spark-on-k8s-operator experimental addon

Fixes #695

How has this code been tested?

The change has been tested following the github actions:
go mod tidy
(cd addons && go run ../hack/addons/syn_addon_package.go ./ https://kubevela.github.io/catalog/official)
(cd experimental/addons && go run ../../hack/addons/syn_addon_package.go ./https://kubevela.github.io/catalog/experimental)

Checklist

I have:

  • Title of the PR starts with type (e.g. [Addon] , [example] or [Doc]).
  • Updated/Added any relevant documentation and examples.
  • New addon should be put in experimental.
  • Update addon should modify the version in metadata.yaml to generate a new version.

@scodeman
Copy link
Author

scodeman commented Aug 2, 2023

Regarding the failed addon-e2e test.
The changes of the following files are to make the original addon chart proper as vela expect a mandatory template.cue file
(even with empty output) for the addon.

  • addons/o11y-definitions/template.cue
  • addons/vegeta/template.cue
  • experimental/addons/canary-rollout-istio/template.cue
  • experimental/addons/envoy-gateway/template.cue
  • experimental/addons/vector-config/template.cue

The chart version seems unfortunately to be linked to the actual addon application tag in github (instead of using appVersion) so I am not sure my PR has to update the chart version, should it ?

@wangyikewxgm
Copy link
Collaborator

Thanks, please refer the failed CI info and fix them.

@scodeman scodeman force-pushed the vela_addon_charts branch 2 times, most recently from d539e91 to c9335d6 Compare September 11, 2023 03:34
@scodeman
Copy link
Author

Note that I could not use semver build metadata due to kubernetes/kubernetes#115055 issue

@scodeman
Copy link
Author

scodeman commented Sep 11, 2023

Thanks, please refer the failed CI info and fix them.

Hi @wangyikewxgm , @wonderflow, @barnettZQG, @Somefive, done, waiting for your review

@scodeman scodeman requested a review from wonderflow December 20, 2023 15:25
wonderflow
wonderflow previously approved these changes Dec 25, 2023
@wonderflow
Copy link
Collaborator

ping @Somefive @barnettZQG , please help review, this feature can be useful.

@scodeman
Copy link
Author

scodeman commented May 2, 2024

ping @Somefive @barnettZQG , @wangyikewxgm please help review.

scodeman and others added 8 commits September 5, 2025 10:25
Signed-off-by: florent.madiot.e <florent.madiot.e@thalesdigital.io>
Signed-off-by: florent.madiot.e <florent.madiot.e@thalesdigital.io>
Signed-off-by: florent.madiot.e <florent.madiot.e@thalesdigital.io>
Signed-off-by: florent.madiot.e <florent.madiot.e@thalesdigital.io>
Signed-off-by: florent.madiot.e <florent.madiot.e@thalesdigital.io>
…ue file

Signed-off-by: florent.madiot.e <florent.madiot.e@thalesdigital.io>
…s labels not fully supporting semver

Signed-off-by: florent.madiot.e <florent.madiot.e@thalesdigital.io>
Signed-off-by: florent.madiot.e <florent.madiot.e@thalesdigital.io>
@scodeman
Copy link
Author

scodeman commented Sep 5, 2025

Rebased the MR

Signed-off-by: florent.madiot.e <florent.madiot.e@thalesdigital.io>
@scodeman
Copy link
Author

Waiting on #783 to be merge to rebase and have dependencies issues resolved

@scodeman scodeman requested a review from jguionnet as a code owner January 20, 2026 03:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing Chart.yaml in addon charts

3 participants