Skip to content

CNV-67729: support multiple yaml paths in a filter key#35

Merged
metalice merged 1 commit intokubevirt-ui:mainfrom
adamviktora:filters-support-multiple-keys
Nov 18, 2025
Merged

CNV-67729: support multiple yaml paths in a filter key#35
metalice merged 1 commit intokubevirt-ui:mainfrom
adamviktora:filters-support-multiple-keys

Conversation

@adamviktora
Copy link
Member

@adamviktora adamviktora commented Sep 5, 2025

  • adds support for multiple yaml path in a filter key
    • key should be formatted as some.spec|some.other.spec
    • needed for filter by Operating system to work on the proxy side
  • refactoring of a nested for loop

Demo example of using this updated proxy on OS filter:

Before:

Screen.Recording.2025-11-10.at.12.55.26.mov

After:

Screen.Recording.2025-11-10.at.13.03.04.mov

- key should be formatted as some.spec|some.other.spec
- needed for filter by Operating system
- refactoring of a nested for loop
@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Sep 5, 2025

@adamviktora: This pull request references CNV-67729 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.21.0" version, but no target version was set.

Details

In response to this:

  • adds support for multiple yaml paths as filter keys
  • key should be formatted as some.spec|some.other.spec
  • needed for filter by Operating system to work on the proxy side
  • refactoring of a nested for loop

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@adamviktora adamviktora changed the title CNV-67729: support multiple yaml paths as filter keys CNV-67729: support multiple yaml paths in a filter key Sep 5, 2025
@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Sep 5, 2025

@adamviktora: This pull request references CNV-67729 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.21.0" version, but no target version was set.

Details

In response to this:

  • adds support for multiple yaml path in a filter key
  • key should be formatted as some.spec|some.other.spec
  • needed for filter by Operating system to work on the proxy side
  • refactoring of a nested for loop

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Nov 10, 2025

@adamviktora: This pull request references CNV-67729 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.21.0" version, but no target version was set.

Details

In response to this:

  • adds support for multiple yaml path in a filter key
  • key should be formatted as some.spec|some.other.spec
  • needed for filter by Operating system to work on the proxy side
  • refactoring of a nested for loop

Demo example of using this updated proxy on OS filter:

Before:

Screen.Recording.2025-11-10.at.12.55.26.mov

After:

Screen.Recording.2025-11-10.at.13.03.04.mov

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link

openshift-ci bot commented Nov 18, 2025

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: adamviktora, metalice

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metalice metalice merged commit 9e6853c into kubevirt-ui:main Nov 18, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants