[release-4.19] CNV-79541: Fix incorrect minimum disk size validation for CD-ROM

[upalatucci]

This is a manual cherry-pick of #3462 to release-4.19

The core fix changes the showSizeInput logic in SelectSource to correctly differentiate between CD-ROM and disk sources:

• For disk sources: show size input for all source types except container disk
• For CD sources: show size input only for HTTP and upload sources

This replaces the old withSize prop with a diskSource boolean prop and refactors the conditional logic accordingly.

Note: The min disk size validation (minDiskValue/isMinusDisabled) from the 4.20 version was omitted because the required dependencies (getRootDiskStorageRequests, getIsMinusDisabled, getMinDiskSize, originalTemplate in drawer context) do not exist on the release-4.19 branch. This is acceptable because the min disk size validation was never present on release-4.19.

/assign upalatucci

Made with Cursor

[openshift-ci-robot]

@upalatucci: This pull request references CNV-79541 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.19.z" version, but no target version was set.

Details

In response to this:

This is a manual cherry-pick of #3462 to release-4.19

The core fix changes the showSizeInput logic in SelectSource to correctly differentiate between CD-ROM and disk sources:

• For disk sources: show size input for all source types except container disk
• For CD sources: show size input only for HTTP and upload sources

This replaces the old withSize prop with a diskSource boolean prop and refactors the conditional logic accordingly.

Note: The min disk size validation (minDiskValue/isMinusDisabled) from the 4.20 version was omitted because the required dependencies (getRootDiskStorageRequests, getIsMinusDisabled, getMinDiskSize, originalTemplate in drawer context) do not exist on the release-4.19 branch. This is acceptable because the min disk size validation was never present on release-4.19.

/assign upalatucci

Made with Cursor

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: upalatucci

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [upalatucci]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}