-
Notifications
You must be signed in to change notification settings - Fork 305
Enable CSI cloning functionality when CDI populators are disabled #3902
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Enable CSI cloning functionality when CDI populators are disabled #3902
Conversation
This change is a draft attempt to allow DataVolumes to use CSI volume cloning (instead of falling back to host-assisted clone strategy) even when the usePopulator feature is set to false, providing direct cloning for storage classes that support CSI clone operations. added csi-clone support for both pvc and snapshot sources - withing the cloning process, PVC with a dataSource/dataSourceRef pointing to the pvc/volumesnapshot will be created. Signed-off-by: Noam Assouline <[email protected]>
|
Hi @noamasu. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
I would really prefer that we instead help Portworx overcome their issue with using populators - /cc @mhenriks |
This will definitely be a maintenance burden but also don't forget that without populators we cannot support |
|
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with /lifecycle stale |
|
Stale issues rot after 30d of inactivity. If this issue is safe to close now please do so with /lifecycle rotten |
This draft introduces an attempt to allow DataVolumes to use CSI volume cloning (instead of falling back to host-assisted clone strategy) even when the usePopulator feature is set to false, providing direct cloning for storage classes that support CSI clone operations.
added csi-clone support for both pvc and snapshot sources - withing the cloning process, PVC with a dataSource/dataSourceRef pointing to the pvc/volumesnapshot will be created.
What this PR does / why we need it:
Following our discussion about Portworx’s set of the userPopulator field to false, we decided to reintroduce the ability to perform a CSI-based clone even without CDI populators. This avoids falling back to host-assisted cloning, which significantly increases clone completion time.
Which issue(s) this PR fixes *
Jira Ticket: https://issues.redhat.com/browse/CNV-66958
for additional context:
The PR that removed csi-cloning after introducing CDI populators: 2285ceb#r1235350852
Special notes for your reviewer:
@alromeros
@akalenyu
Release note: