Skip to content

Tests: Remove AI-generated artifacts from tests#409

Merged
kubevirt-bot merged 1 commit intokubevirt:mainfrom
alromeros:remove-ai-docs
Mar 27, 2026
Merged

Tests: Remove AI-generated artifacts from tests#409
kubevirt-bot merged 1 commit intokubevirt:mainfrom
alromeros:remove-ai-docs

Conversation

@alromeros
Copy link
Copy Markdown
Member

What this PR does / why we need it:

This PR removes unnecessary ai-generated docs that were mistakenly included in #404.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Release note:

NONE

This commit removes ai-generated docs that were mistakenly included in kubevirt#404.

Signed-off-by: Alvaro Romero <alromero@redhat.com>
@kubevirt-bot kubevirt-bot added the dco-signoff: yes Indicates the PR's author has DCO signed all their commits. label Mar 27, 2026
@alromeros
Copy link
Copy Markdown
Member Author

@weshayutin let me know if you are ok with these changes.

Copy link
Copy Markdown
Contributor

@weshayutin weshayutin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well.. until it's socialized that these tests were running the WRONG types of backups I would like to leave it. In the branches other than main, the tests run volumesnapshot backups and restic backups, neither are supported by velero for vm's.
The backups were also not waiting to start until the vm's were fully up, causing race conditional failures.

Now moving to CSI - supported
Now waiting for VM and Volumes to be running and bound.
Now we're testing what is actually supported.

So actually, this can be rewritten or moved but not removed entirely. That's my opinion, but I'm not in charge :)

@kubevirt-bot
Copy link
Copy Markdown

@weshayutin: changing LGTM is restricted to collaborators

Details

In response to this:

well.. yes we can remove. However until it's socialized that these tests were running the WRONG types of backups I would like to leave it. In the branches other than main, the tests run volumesnapshot backups and restic backups, neither are supported by velero for vm's.
The backups were also not waiting to start until the vm's were fully up, causing race conditional failures.

Now moving to CSI - supported
Now waiting for VM and Volumes to be running and bound.
Now we're testing what is actually supported.

So actually, this can be rewritten or moved but not removed entirely. That's my opinion, but I'm not in charge :)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Copy Markdown
Contributor

@weshayutin weshayutin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ya.. I need to make sure we communicate what was changed, especially to QE.

@kubevirt-bot
Copy link
Copy Markdown

@weshayutin: changing LGTM is restricted to collaborators

Details

In response to this:

ya.. I need to make sure we communicate what was changed, especially to QE.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Copy Markdown
Contributor

@weshayutin weshayutin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0/ approved
/LGTM

@kubevirt-bot
Copy link
Copy Markdown

@weshayutin: changing LGTM is restricted to collaborators

Details

In response to this:

0/ approved
/LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@alromeros
Copy link
Copy Markdown
Member Author

/lgtm
/approve
Merging as discussed in #404. Thanks @weshayutin!

@kubevirt-bot
Copy link
Copy Markdown

@alromeros: you cannot LGTM your own PR.

Details

In response to this:

/lgtm
/approve
Merging as discussed in #404. Thanks @weshayutin!

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kubevirt-bot
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alromeros

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 27, 2026
@awels
Copy link
Copy Markdown
Member

awels commented Mar 27, 2026

/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 27, 2026
@kubevirt-bot kubevirt-bot merged commit d2e45cc into kubevirt:main Mar 27, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. size/L

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants