Tests: Remove AI-generated artifacts from tests#409
Tests: Remove AI-generated artifacts from tests#409kubevirt-bot merged 1 commit intokubevirt:mainfrom
Conversation
This commit removes ai-generated docs that were mistakenly included in kubevirt#404. Signed-off-by: Alvaro Romero <alromero@redhat.com>
|
@weshayutin let me know if you are ok with these changes. |
There was a problem hiding this comment.
well.. until it's socialized that these tests were running the WRONG types of backups I would like to leave it. In the branches other than main, the tests run volumesnapshot backups and restic backups, neither are supported by velero for vm's.
The backups were also not waiting to start until the vm's were fully up, causing race conditional failures.
Now moving to CSI - supported
Now waiting for VM and Volumes to be running and bound.
Now we're testing what is actually supported.
So actually, this can be rewritten or moved but not removed entirely. That's my opinion, but I'm not in charge :)
|
@weshayutin: changing LGTM is restricted to collaborators DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
weshayutin
left a comment
There was a problem hiding this comment.
ya.. I need to make sure we communicate what was changed, especially to QE.
|
@weshayutin: changing LGTM is restricted to collaborators DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@weshayutin: changing LGTM is restricted to collaborators DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/lgtm |
|
@alromeros: you cannot LGTM your own PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alromeros The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
What this PR does / why we need it:
This PR removes unnecessary ai-generated docs that were mistakenly included in #404.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Release note: