feat(overcommit): add TimeBounds for cron overcommit #95
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WangZzzhe
force-pushed
the
dev/cron-overcommit
branch
from
83f0907 to
d5d7bef
Compare
caohe
reviewed
Aug 28, 2024
| TimeBounds []TimeBound `json:"timeBounds,omitempty"` | ||
|
|
||
| // If CronConsistency is true, controller will ensure ResourceOvercommitRatio is consistent with the configuration of the TimeBound that should have been executed last time | ||
| CronConsistency bool `json:"CronConsistency"` |
Member
There was a problem hiding this comment.
Field names should start with a lowercase letter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Enhancements
What this PR does / why we need it:
Which issue(s) this PR fixes:
Special notes for your reviewer: