Skip to content

Conversation

@WangZzzhe
Copy link
Collaborator

What type of PR is this?

Enhancements

What this PR does / why we need it:

Add parameter MaxNodeUtilizationPercent,which will be converted to reservedForAllocated to limit the total amount of reclaimed resources.

PR should be updated after kubewharf/katalyst-api#85 is merged

@WangZzzhe WangZzzhe self-assigned this May 23, 2024
@WangZzzhe WangZzzhe added enhancement New feature or request workflow/need-review review: test succeeded, need to review labels May 23, 2024
@codecov
Copy link

codecov bot commented May 23, 2024

Codecov Report

❌ Patch coverage is 72.00000% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 57.03%. Comparing base (99996fc) to head (dbc797f).
⚠️ Report is 757 commits behind head on main.

Files with missing lines Patch % Lines
...minqos/reclaimedresource/reclaimedresource_base.go 55.55% 3 Missing and 1 partial ⚠️
...ce/memory/plugin/provisioner/memory_provisioner.go 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #592      +/-   ##
==========================================
- Coverage   57.18%   57.03%   -0.16%     
==========================================
  Files         558      566       +8     
  Lines       54146    54508     +362     
==========================================
+ Hits        30966    31087     +121     
- Misses      19305    19510     +205     
- Partials     3875     3911      +36     
Flag Coverage Δ
unittest 57.03% <72.00%> (-0.16%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@WangZzzhe WangZzzhe force-pushed the dev/node-utilization-percent branch from a666b97 to 9f2e149 Compare July 18, 2024 13:30
@WangZzzhe WangZzzhe requested a review from xu282934741 as a code owner July 18, 2024 13:30
@WangZzzhe WangZzzhe force-pushed the dev/node-utilization-percent branch from 9f2e149 to dbc797f Compare August 28, 2024 08:21
c.MemoryHeadroomConfiguration.ApplyConfiguration(conf)
}

func (c *ReclaimedResourceConfiguration) GetReservedResourceForAllocate(nodeResourceList v1.ResourceList) v1.ResourceList {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It may be better for GetReservedResourceForAllocate to use resource name and quantity as two separate input parameters.

@xu282934741 xu282934741 added workflow/draft draft: no need to review and removed workflow/need-review review: test succeeded, need to review labels Jun 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request workflow/draft draft: no need to review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants