Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🔍 PR Validation ReportStatus: ❌ FAILED ✅ Validation Results
🎯 Next StepsPlease fix the failing checks before this PR can be merged. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f0802c0b85
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if (rf) { | ||
| nodeRef.current[index] = rf; | ||
| } |
There was a problem hiding this comment.
Reset node ref slot when a NodePath unmounts
React calls callback refs with null on unmount, but this guard ignores that path and leaves the previous DOM node in nodeRef.current[index]. When the number of points decreases (or nodes are conditionally removed), downstream code that uses innerRefs.current.node for keyboard focus and synthetic click dispatch can still target stale, detached nodes instead of the current rendered set, producing incorrect focus/click behavior after data updates.
Useful? React with 👍 / 👎.
🔍 PR Validation ReportStatus: ❌ FAILED ✅ Validation Results
🎯 Next StepsPlease fix the failing checks before this PR can be merged. |
🚀 Package PublishedVersion bump type:
✅ Package has been successfully published to NPM! |
No description provided.