Skip to content

feat(core): update peerdependencies#23

Merged
hectoruch merged 2 commits intomainfrom
feat/react-external-dependency
Feb 20, 2026
Merged

feat(core): update peerdependencies#23
hectoruch merged 2 commits intomainfrom
feat/react-external-dependency

Conversation

@hectoruch
Copy link
Contributor

No description provided.

@vercel
Copy link

vercel bot commented Feb 20, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
kubit-react-charts Ready Ready Preview, Comment Feb 20, 2026 7:56am

@github-actions
Copy link
Contributor

🔍 PR Validation Report

Status: ❌ FAILED
Branch: feat/react-external-dependency
Expected Version Bump: minor

✅ Validation Results

Check Status Description
Branch Naming ✅ Pass Must follow type/description
PR Title ❌ Fail Must follow conventional commits
Title Length ⚠️ Warning Should be ≤72 characters
TypeScript ❌ Fail Type checking validation
Tests ❌ Fail All tests must pass
Code Quality ✅ Pass No console.log in production
TODOs ✅ Pass TODOs should reference issues

🎯 Next Steps

Please fix the failing checks before this PR can be merged.

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f0802c0b85

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +236 to +238
if (rf) {
nodeRef.current[index] = rf;
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Reset node ref slot when a NodePath unmounts

React calls callback refs with null on unmount, but this guard ignores that path and leaves the previous DOM node in nodeRef.current[index]. When the number of points decreases (or nodes are conditionally removed), downstream code that uses innerRefs.current.node for keyboard focus and synthetic click dispatch can still target stale, detached nodes instead of the current rendered set, producing incorrect focus/click behavior after data updates.

Useful? React with 👍 / 👎.

@github-actions
Copy link
Contributor

🔍 PR Validation Report

Status: ❌ FAILED
Branch: feat/react-external-dependency
Expected Version Bump: minor

✅ Validation Results

Check Status Description
Branch Naming ✅ Pass Must follow type/description
PR Title ❌ Fail Must follow conventional commits
Title Length ⚠️ Warning Should be ≤72 characters
TypeScript ❌ Fail Type checking validation
Tests ❌ Fail All tests must pass
Code Quality ✅ Pass No console.log in production
TODOs ✅ Pass TODOs should reference issues

🎯 Next Steps

Please fix the failing checks before this PR can be merged.

@hectoruch hectoruch merged commit 265dd76 into main Feb 20, 2026
3 checks passed
@github-actions
Copy link
Contributor

🚀 Package Published

Version bump type: patch

Package Version NPM Link
@kubit-ui-web/react-charts 1.11.4 View on NPM

✅ Package has been successfully published to NPM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant