Open
Conversation
53a7fda to
0f44000
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey there! Thank you for the library! I am using it in one of my zig projects and noticed that I couldn't parse yaml with block scalars. When the parser encountered these indicators, it would fail with parsing errors.
I implemented basic support for YAML block scalars by:
1. Tokenizer Enhancements (
src/Tokenizer.zig)block_literal(|) andblock_folded(>)2. Parser Implementation (
src/Parser.zig)blockScalar()function to handle block scalar parsingvalue()function to dispatch toblockScalar()when these tokens are encountered3. Examples Created
examples/block_scalars.yml- Simple demonstrationexamples/block_scalar_demo.yml- Comprehensive examples with real-world use casesWould love it if we can merge this in, but no worries if not! I know this PR came out of the blue (and I'll update my dep to use my fork in the meantime 😄). Thanks again!