fix: remove extra requirement for doc end marker#80
Open
wemeetagain wants to merge 1 commit intokubkon:mainfrom
Open
fix: remove extra requirement for doc end marker#80wemeetagain wants to merge 1 commit intokubkon:mainfrom
wemeetagain wants to merge 1 commit intokubkon:mainfrom
Conversation
Contributor
wemeetagain
commented
Apr 11, 2025
wemeetagain
commented
- fixes bug: document end marker w/o directive end marker throws error #79
kubkon
requested changes
Apr 13, 2025
Owner
kubkon
left a comment
kubkon
left a comment
There was a problem hiding this comment.
Looks great, thanks! Can you also have a look in the specs tests test/spec.zig if we can check if we pass any additional tests? For example, "HWV9 - Document-end marker" looks promising but so far it's been commented out.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.