Open
Conversation
kubkon
reviewed
Jun 24, 2025
| inline for (struct_info.fields) |field| { | ||
| var value: ?Value = map.get(field.name) orelse blk: { | ||
| const field_name = try mem.replaceOwned(u8, arena, field.name, "_", "-"); | ||
| defer arena.free(field_name); |
Owner
There was a problem hiding this comment.
Hmm, this looks sus to me. Why would we need to specifically free field_name if it's allocated in an arena and hence should be freed upon freeing the entire arena.
Contributor
Author
There was a problem hiding this comment.
I'm not sure but if you look at the error, you'll see that GPA does complain.
Owner
There was a problem hiding this comment.
When reporting the issue, did you use an arena, or did you pass a GPA instead?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #93