feat(route-engine): harden transport mode generation - #1560
Merged
Conversation
kubohiroya
commented
Aug 23, 2026
kubohiroya
left a comment
Owner
Author
There was a problem hiding this comment.
Reviewed the PR diff for route engine capability enforcement, OSRM option strictness, route MVT layer constants, tileIndex usage comments, and matching spec/test updates. No blocking issues found.
Local verification before PR:
- pnpm exec biome check --write -> exit 0
- pnpm -w turbo run typecheck --filter @hierarchidb/route-api --filter @hierarchidb/route-engine --filter @hierarchidb/route-plugin --filter @hierarchidb/runtime-worker --filter @hierarchidb/app -> exit 0
- pnpm -w turbo run test --filter @hierarchidb/route-engine --filter @hierarchidb/route-plugin -> exit 0
- git diff --check -> exit 0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Issues
Verification
pnpm install-> exit 0 (existing gen-iso3166-2 bin warnings)pnpm exec biome check --write <touched source files>-> exit 0pnpm -w turbo run typecheck --filter @hierarchidb/route-api --filter @hierarchidb/route-engine --filter @hierarchidb/route-plugin --filter @hierarchidb/runtime-worker --filter @hierarchidb/app-> exit 0pnpm -w turbo run test --filter @hierarchidb/route-engine --filter @hierarchidb/route-plugin-> exit 0git diff --check-> exit 0Rollback