Skip to content

feat(route-engine): harden transport mode generation - #1560

Merged
kubohiroya merged 2 commits into
mainfrom
feat/route-engine/transport-mode-generators
Aug 23, 2026
Merged

feat(route-engine): harden transport mode generation#1560
kubohiroya merged 2 commits into
mainfrom
feat/route-engine/transport-mode-generators

Conversation

@kubohiroya

Copy link
Copy Markdown
Owner

Summary

  • enforce routeMode-aware route engine capability validation for generated route requests
  • make OSRM generation options explicit and fail-fast instead of defaulting profile/geometries/overview
  • share route MVT source-layer/promoteId constants across geometry artifacts, preview, and folder map rendering
  • document RouteDB.tileIndex as nearest-search/legacy cleanup only, not canonical tile lineage

Issues

Verification

  • pnpm install -> exit 0 (existing gen-iso3166-2 bin warnings)
  • pnpm exec biome check --write <touched source files> -> exit 0
  • pnpm -w turbo run typecheck --filter @hierarchidb/route-api --filter @hierarchidb/route-engine --filter @hierarchidb/route-plugin --filter @hierarchidb/runtime-worker --filter @hierarchidb/app -> exit 0
  • pnpm -w turbo run test --filter @hierarchidb/route-engine --filter @hierarchidb/route-plugin -> exit 0
  • git diff --check -> exit 0

Rollback

  • Revert this PR to restore the prior route generation and route MVT rendering contracts.
  • Existing persisted MVT artifacts remain derived data and can be regenerated per node.

@kubohiroya kubohiroya left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the PR diff for route engine capability enforcement, OSRM option strictness, route MVT layer constants, tileIndex usage comments, and matching spec/test updates. No blocking issues found.

Local verification before PR:

  • pnpm exec biome check --write -> exit 0
  • pnpm -w turbo run typecheck --filter @hierarchidb/route-api --filter @hierarchidb/route-engine --filter @hierarchidb/route-plugin --filter @hierarchidb/runtime-worker --filter @hierarchidb/app -> exit 0
  • pnpm -w turbo run test --filter @hierarchidb/route-engine --filter @hierarchidb/route-plugin -> exit 0
  • git diff --check -> exit 0

@kubohiroya
kubohiroya merged commit 9e544a7 into main Aug 23, 2026
2 checks passed
@kubohiroya
kubohiroya deleted the feat/route-engine/transport-mode-generators branch August 23, 2026 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

1 participant