Skip to content

test(fdm): cover workflow and ruleset projections - #1751

Merged
kubohiroya merged 1 commit into
mainfrom
codex/fdm-1731-l4-l5-projection-followthrough
Sep 8, 2026
Merged

test(fdm): cover workflow and ruleset projections#1751
kubohiroya merged 1 commit into
mainfrom
codex/fdm-1731-l4-l5-projection-followthrough

Conversation

@kubohiroya

Copy link
Copy Markdown
Owner

Summary

Scope

Validation

  • pnpm -w turbo run test typecheck build --filter @hierarchidb/fdm-api
  • pnpm -w turbo run test typecheck build --filter @hierarchidb/fdm-plugin
  • pnpm -w exec biome check packages/fdm-api/src/__tests__/fdmDashboardValidators.test.ts plugins/fdm-plugin/src/ui/dashboard/FdmDashboardPresentation.tsx plugins/fdm-plugin/src/ui/dashboard/__tests__/FdmDashboardView.test.tsx docs/fdm-seven-layer-contract-audit.md
  • git diff --check

Note: the first sandboxed pnpm attempt failed while fetching/verifying pnpm registry signatures. The same validation was rerun with network-capable execution and passed.

Rollback

Revert this PR. The change is limited to projection metadata display, tests, and audit documentation; it does not add workflow/ruleset mutation behavior or local decision logic.

Closes #1731

@kubohiroya

Copy link
Copy Markdown
Owner Author

自己レビュー結果(2026-09-08 JST)

差分を確認しました。今回の変更は #1731 の L4/L5 projection coverage 補強に限定され、workflow/ruleset の状態判断、acceptance/waiver mutation、runtime event からの推論は追加していません。

確認ポイント:

  • validator test は Render L4 workflow and L5 ruleset projections without client-side decisions #1731 に列挙された workflow status / operation status / operation outcome / nextAction を明示的に受理し、既存の unknown enum rejection を維持しています。
  • UI test は server-provided projection のラベル/message を表示するだけで、クライアント側の解釈や action enablement 条件を変更していません。
  • ruleset fingerprint/digest は、サーバ提供 metadata として表示するだけです。

指摘事項: なし。

検証:

  • pnpm -w turbo run test typecheck build --filter @hierarchidb/fdm-api: pass
  • pnpm -w turbo run test typecheck build --filter @hierarchidb/fdm-plugin: pass
  • pnpm -w exec biome check 対象ファイル: pass
  • git diff --check: pass

補足: 最初の sandboxed pnpm 実行は pnpm registry signature fetch/verification で失敗しましたが、network-capable execution で同じ検証を再実行して pass しています。

@kubohiroya
kubohiroya merged commit d54e151 into main Sep 8, 2026
7 checks passed
@kubohiroya
kubohiroya deleted the codex/fdm-1731-l4-l5-projection-followthrough branch September 8, 2026 03:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Render L4 workflow and L5 ruleset projections without client-side decisions

1 participant