Remove Arel::Visitors::DepthFirst / Add Rails 8.1 support for Arel::Nodes::Function #20
+49
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a5-stable
changed the title
a5-stable
changed the title
a5-stable
changed the title
a5-stable
commented
Jan 24, 2026
| end | ||
|
|
||
| if Gem::Version.new('7.3.0') <= Sidekiq.gem_version && Sidekiq.gem_version < Gem::Version.new('8.0.0') | ||
| if Gem::Version.new('7.3.0') <= Sidekiq.gem_version && Sidekiq.gem_version < Gem::Version.new('7.3.10') |
Collaborator
Author
There was a problem hiding this comment.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## features #20 +/- ##
===========================================
Coverage ? 86.59%
===========================================
Files ? 17
Lines ? 791
Branches ? 0
===========================================
Hits ? 685
Misses ? 106
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Arel::Visitors::DepthFirst was already removed in this PR. Since we only support Rails 7.1 and later, we do not need to handle it.
From Rails 8.1,
Arel::Nodes::Functionno longer has an alias attribute; aliasing is now handled viaAliasPredication#as(Ensure function aliases allow retrying queries rails/rails#54824).