feat: Add datatype enum. #15
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Adding the DataType enum could be a breaking change for users who are only using it as string. Therefore this PR maybe pending for next major release. |
|
I would argue that it will only be a breaking change if using it to parse schemas that are invalid from the OpenAPI spec 😉, but I guess you are technically right. Any idea when you'll release the next major? I was looking to get these changes in to allow this project to be a non-vendored dependency in the aforementioned downstream project 🤔. |
|
@mike-oakley -> youre welcome to submit any and all improvements to https://github.com/starlite-api/pydantic-openapi-schema, we'll gladly release this PR (except for code duplication, which we should strive to reduce when possible). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by upstream changes: openapi-generators/openapi-python-client#478
Adds a DataType enum. This:
Improves validation by rejecting invalid keywords which don't match the spec at parse-time.
Improves developer experience, allows IDE autocompletion to show allowed values.