Move MeshIdentity and MeshTrust into separate modules#4473
Move MeshIdentity and MeshTrust into separate modules#4473
Conversation
❌ Deploy Preview for kuma-gui failed.
|
Co-authored-by: johncowen <554604+johncowen@users.noreply.github.com>
|
@copilot it looks to me like you don't need to register the routes in the new service container config you've added in the I think you can remove the |
Co-authored-by: johncowen <554604+johncowen@users.noreply.github.com>
You're correct! Removed the unnecessary routes registration from both modules in commit 81c7cf1. The routes are now only imported directly where they're used (in meshes and legacy-data-planes modules), while the sources remain registered in the service container. |
Plan: Move MeshIdentity and MeshTrust into their own modules
Summary
Successfully moved MeshIdentity and MeshTrust from the generic
resourcesmodule into their own dedicated modules following the "one module per resource" pattern established in the codebase.Changes Completed
Create new
/app/mesh-identities/module with:data/MeshIdentity.ts(moved from resources)views/MeshIdentitySummaryView.vue(moved from resources)index.ts(new - service registration)routes.ts(new - route definitions)sources.ts(new - data sources)Create new
/app/mesh-trusts/module with:data/MeshTrust.ts(moved from resources)views/MeshTrustSummaryView.vue(moved from resources)index.ts(new - service registration)routes.ts(new - route definitions)sources.ts(new - data sources)Update imports in:
/app/service-mesh/index.ts(add new modules to services)/app/meshes/routes.ts(update route imports)/app/legacy-data-planes/routes.ts(update route imports)Clean up resources module:
resources/index.tsto return empty services arrayFix service container registration:
Files Changed
mesh-identitiesandmesh-trustsTesting
The refactoring maintains all existing functionality:
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.