Conversation
Add targetRef as a concept Signed-off-by: Justin Davies <justin.davies@konghq.com>
justindavies
requested review from
johncowen and
lobkovilya
and removed request for
a team
✅ Deploy Preview for kuma ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
| A **Target** (referenced by `targetRef`) is a way to specify exactly which destination resource or workload a policy or routing rule should apply to. Rather than matching all services or inbounds by name or tag, `targetRef` allows fine-grained targeting of: | ||
|
|
||
| - A specific **workload instance** (e.g., a single Dataplane proxy) | ||
| - A **subset** of inbounds/endpoints for a service |
There was a problem hiding this comment.
If I understand correctly, you are taking here about destination service. Using name inbound in this case is not the best option as we define Inbound as a part of a dataplane proxy. In this case, I think it would be best to call it service port.
|
|
||
| #### Why use `targetRef`? | ||
|
|
||
| - **Precision**: Apply policies only to a single pod, VM, or data-plane proxy. |
There was a problem hiding this comment.
what is the difference between pod/vm and data plane here? I think that you cannot have data plane without vm or pod so maybe we can remove it?
| Policies always have a clear specific area of impact and goal. | ||
| To learn more about [policies checkout the in depth introduction](/docs/{{ page.release }}/policies/introduction). | ||
|
|
||
| ### Targets (targetRef) |
There was a problem hiding this comment.
Are you planing on using targets as a concept in docs? Maybe we can just call this section targetRef as it is commonly used in docs and can be easily referenced
|
|
||
| ### Targets (targetRef) | ||
|
|
||
| A **Target** (referenced by `targetRef`) is a way to specify exactly which destination resource or workload a policy or routing rule should apply to. Rather than matching all services or inbounds by name or tag, `targetRef` allows fine-grained targeting of: |
There was a problem hiding this comment.
| A **Target** (referenced by `targetRef`) is a way to specify exactly which destination resource or workload a policy or routing rule should apply to. Rather than matching all services or inbounds by name or tag, `targetRef` allows fine-grained targeting of: | |
| A **Target** (referenced by `targetRef`) is a way to specify exactly which resource a policy or routing rule should apply to. Rather than matching all services or inbounds by name or tag, `targetRef` allows fine-grained targeting of: |
Workloads are also resources in Kuma. We can also link it to previous section with Resource concept.
|
|
||
| ### Targets (targetRef) | ||
|
|
||
| A **Target** (referenced by `targetRef`) is a way to specify exactly which destination resource or workload a policy or routing rule should apply to. Rather than matching all services or inbounds by name or tag, `targetRef` allows fine-grained targeting of: |
There was a problem hiding this comment.
Isn't matching inbounds by name or tag, already fine-grained targeting allowed by targetRef sectionName filed?
|
@justindavies do you have time to work on this? |
3 participants
Adding targetRef as a concept
Did you sign your commit? Instructions
Have you read Contributing guidelines?