chore(tools): migrate frontmatter tests to ShellSpec#2529
Merged
Conversation
Replace custom test runner with ShellSpec for consistency with other tool tests (check-version-urls). Signed-off-by: Marcin Skalski <skalskimarcin33@gmail.com>
Automaat
requested review from
Copilot,
jijiechen and
lobkovilya
and removed request for
a team
✅ Deploy Preview for kuma ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR migrates the frontmatter validation tests from a custom bash test runner to the ShellSpec testing framework, aligning with the project's standardized testing approach for shell scripts.
Key changes:
- Removes custom test runner
test-validate-frontmatter.shwith inline fixture creation and validation logic - Adds ShellSpec test suite
spec/validate_frontmatter_spec.shwith comprehensive coverage and git integration - Enhances test coverage with path exclusion tests for
/generated/and/raw/directories
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tools/test-validate-frontmatter.sh | Deleted custom test runner that validated frontmatter logic without git integration |
| tools/spec/validate_frontmatter_spec.sh | New ShellSpec test suite that tests the actual script in a git context with comprehensive coverage |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
bartsmykla
approved these changes
Nov 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Standardize test tooling - use ShellSpec for all tool tests.
Implementation information
Replace custom test runner
test-validate-frontmatter.shwith ShellSpec tests inspec/validate_frontmatter_spec.sh, matching the pattern used forcheck-version-urlstests.Supporting documentation
Related: #2526