fix(xds): don't create empty filter chain for a gateway #15532
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Delegated gateways with transparent proxy enabled were failing with:
The issue occurs when all these conditions are met:
In
CreateInboundPassthroughListener, the condition ifuseStrictInboundPortswould enter a loop overproxy.Dataplane.Spec.Networking.Inboundto create per-port filter chains. For delegated gateways with no inbounds, this loop produces zero filter chains, causing Envoy to reject the listener.Implementation information
CreateInboundPassthroughListenerfrom ifuseStrictInboundPortsto ifuseStrictInboundPorts && len(proxy.Dataplane.Spec.Networking.Inbound) > 0