add some asynchronous callbacks for aioshutil #15
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found this library after seeing a draft from multidict so I thought about contributing over here since I got rather curious.
I had an idea for making aioshutil support asynchronous callbacks but I will still say my idea/concept is in it's beta-phase.
It may require getting a bit deeper into shutil's actual code depending on some different circumstances.
So far I have done
rmtreeand added in an asynchronous callback but so far I think I would like for that callback to be awaited upon so it may need further implementing such as having internal calls to some different os functions but via using eventloop executors.I wanted to do the same with
copyfileobjsince that seems to be an issue at the moment perhaps there could be a secondary function just for that functionality maybe?fixes #12