Prevent stdout writes from corrupting MCP stdio transport#102
Open
BlazStojanovic wants to merge 2 commits intomainfrom
Open
Prevent stdout writes from corrupting MCP stdio transport#102BlazStojanovic wants to merge 2 commits intomainfrom
BlazStojanovic wants to merge 2 commits intomainfrom
Conversation
The base ProgressLogger unconditionally writes OSC escape sequences to sys.stdout in __enter__/__exit__, which corrupts JSON-RPC messages on the stdio transport. Introduce McpProgressLogger that overrides the context manager to preserve timing and log collection while skipping all stdout writes.
for more information, see https://pre-commit.ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #101
The base ProgressLogger unconditionally writes OSC escape sequences to
sys.stdoutin__enter__/__exit__, which corruptsJSON-RPCmessages on thestdiotransport.Introduce
McpProgressLoggerthat overrides the context manager to preserve timing and log collection while skipping all stdout writes.Other workarounds for
kumoai>=2.15