Skip to content

Conversation

@kunitoki
Copy link
Owner

@kunitoki kunitoki commented Jun 10, 2025

image

  • Full text editing, single and multiline
  • Key and mouse selection support
  • Cursor key navigation
  • Cut/Copy/Paste
  • System clipboard

kunitoki and others added 10 commits June 9, 2025 16:52
# Conflicts:
#	docs/YUP Module Format.md
#	guidelines.md
#	modules/juce_audio_basics/juce_audio_basics.h
#	modules/juce_core/juce_core.h
#	modules/yup_gui/widgets/yup_TextButton.cpp
#	modules/yup_gui/yup_gui.cpp
@kunitoki kunitoki requested a review from Copilot June 10, 2025 21:52

This comment was marked as outdated.

@codecov-commenter
Copy link

codecov-commenter commented Jun 10, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 25.66667% with 223 lines in your changes missing coverage. Please review.

Project coverage is 39.52%. Comparing base (53f3d80) to head (53e588f).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
modules/yup_graphics/fonts/yup_StyledText.cpp 13.65% 177 Missing ⚠️
...p_graphics/native/yup_GraphicsContext_headless.cpp 26.22% 45 Missing ⚠️
modules/yup_graphics/graphics/yup_Graphics.cpp 87.50% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #55      +/-   ##
==========================================
+ Coverage   37.86%   39.52%   +1.66%     
==========================================
  Files         302      303       +1     
  Lines       29092    29364     +272     
==========================================
+ Hits        11015    11607     +592     
+ Misses      18077    17757     -320     
Files with missing lines Coverage Δ
modules/yup_core/misc/yup_Functional.h 100.00% <100.00%> (ø)
modules/yup_graphics/context/yup_GraphicsContext.h 66.66% <ø> (+66.66%) ⬆️
modules/yup_graphics/fonts/yup_StyledText.h 100.00% <ø> (+100.00%) ⬆️
modules/yup_graphics/graphics/yup_Graphics.h 86.20% <ø> (+86.20%) ⬆️
...s/yup_graphics/native/yup_GraphicsContext_impl.cpp 44.44% <100.00%> (+44.44%) ⬆️
modules/yup_graphics/primitives/yup_Path.cpp 19.16% <100.00%> (+19.16%) ⬆️
modules/yup_graphics/graphics/yup_Graphics.cpp 72.59% <87.50%> (+72.59%) ⬆️
...p_graphics/native/yup_GraphicsContext_headless.cpp 26.22% <26.22%> (ø)
modules/yup_graphics/fonts/yup_StyledText.cpp 20.10% <13.65%> (+20.10%) ⬆️

... and 11 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa19e22...53e588f. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@kunitoki kunitoki requested a review from Copilot June 11, 2025 16:51
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

A headless rendering backend and a new text‐editing example are added, the StyledText API is modernized, and example build scripts are updated for namespaced modules.

  • Introduce Headless API case with a no-op implementation for offline rendering.
  • Refactor StyledText to use const correctness and an RAII TextModifier for batch updates.
  • Add TextEditorDemo example (single/multi-line editing, selection, copy/paste) and update examples’ CMake targets to yup::-qualified module names.

Reviewed Changes

Copilot reviewed 51 out of 51 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
modules/yup_graphics/native/yup_GraphicsContext_impl.cpp Add Api::Headless branch to createContext.
modules/yup_graphics/native/yup_GraphicsContext_headless.cpp Implement no-op headless GraphicsContext and related factories.
modules/yup_graphics/graphics/yup_Graphics.h/.cpp Make fillFittedText/strokeFittedText take const StyledText&; guard against stale text in rendering.
modules/yup_graphics/fonts/yup_StyledText.h Introduce TextModifier nested class, needsUpdate(), and sibling setters.
examples/graphics/source/examples/TextEditor.h New TextEditorDemo example with text editor widgets.
examples/**/CMakeLists.txt (multiple) Change example and plugin modules to yup::yup_* namespace aliases.
Comments suppressed due to low confidence (1)

examples/graphics/source/examples/TextEditor.h:22

  • TextEditorDemo uses std::unique_ptr and several YUP UI classes but doesn’t include <memory>, "yup/TextEditor.h", "yup/TextButton.h", or "yup/Label.h". Add these headers to avoid compilation errors.
class TextEditorDemo : public yup::Component

@kunitoki kunitoki merged commit 148d38b into main Jun 12, 2025
@kunitoki kunitoki deleted the dev/text_editor branch June 12, 2025 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants