-
Notifications
You must be signed in to change notification settings - Fork 15
Text Editor #55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Text Editor #55
Conversation
# Conflicts: # docs/YUP Module Format.md # guidelines.md # modules/juce_audio_basics/juce_audio_basics.h # modules/juce_core/juce_core.h # modules/yup_gui/widgets/yup_TextButton.cpp # modules/yup_gui/yup_gui.cpp
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #55 +/- ##
==========================================
+ Coverage 37.86% 39.52% +1.66%
==========================================
Files 302 303 +1
Lines 29092 29364 +272
==========================================
+ Hits 11015 11607 +592
+ Misses 18077 17757 -320
... and 11 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
A headless rendering backend and a new text‐editing example are added, the StyledText API is modernized, and example build scripts are updated for namespaced modules.
- Introduce
HeadlessAPI case with a no-op implementation for offline rendering. - Refactor
StyledTextto use const correctness and an RAIITextModifierfor batch updates. - Add
TextEditorDemoexample (single/multi-line editing, selection, copy/paste) and update examples’ CMake targets toyup::-qualified module names.
Reviewed Changes
Copilot reviewed 51 out of 51 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| modules/yup_graphics/native/yup_GraphicsContext_impl.cpp | Add Api::Headless branch to createContext. |
| modules/yup_graphics/native/yup_GraphicsContext_headless.cpp | Implement no-op headless GraphicsContext and related factories. |
| modules/yup_graphics/graphics/yup_Graphics.h/.cpp | Make fillFittedText/strokeFittedText take const StyledText&; guard against stale text in rendering. |
| modules/yup_graphics/fonts/yup_StyledText.h | Introduce TextModifier nested class, needsUpdate(), and sibling setters. |
| examples/graphics/source/examples/TextEditor.h | New TextEditorDemo example with text editor widgets. |
| examples/**/CMakeLists.txt (multiple) | Change example and plugin modules to yup::yup_* namespace aliases. |
Comments suppressed due to low confidence (1)
examples/graphics/source/examples/TextEditor.h:22
- TextEditorDemo uses
std::unique_ptrand several YUP UI classes but doesn’t include<memory>,"yup/TextEditor.h","yup/TextButton.h", or"yup/Label.h". Add these headers to avoid compilation errors.
class TextEditorDemo : public yup::Component
Uh oh!
There was an error while loading. Please reload this page.