+Perfect GroupBy and some old GroupBy algos changes #35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bagrorg
changed the title
| @@ -91,7 +91,8 @@ void PerfectGroupBy::_run(const size_t buf_size, Meter &meter) { | |||
| h.single_task<class clean>([=]() { | |||
| for (size_t i = 0; i < groups_count * threads_count; i++) { | |||
| ht_v[i] = 0; | |||
| o[i] = 0; | |||
| if (i < groups_count) | |||
| o[i] = 0; | |||
There was a problem hiding this comment.
What's the logic behind this one?
There was a problem hiding this comment.
Here we want to clear all output from previous iteration using single_task
However, groups_count * threads_count may be bigger than output array size, so we need to control it to prevent SEGFAULT
This is not so clear, I wanted to do it in one for loop, but is it better to separate this two operations into two single_tasks?
There was a problem hiding this comment.
I guess no big difference since it's a single task
kurapov-peter
approved these changes
Aug 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.