Skip to content

Comments

Add files via upload#5

Open
Robyrob wants to merge 2 commits intokuro68k:masterfrom
Robyrob:master
Open

Add files via upload#5
Robyrob wants to merge 2 commits intokuro68k:masterfrom
Robyrob:master

Conversation

@Robyrob
Copy link

@Robyrob Robyrob commented May 22, 2019

Add path_txt option for chose path for bom_default.txt and bom_subs.txt files
In Pdf creation correct No. bug and Qty. bug
In Pdf changed orientation and eliminated manufactures nr. and notes for my personal use.

This is my first time I pull a request so excuse me

if I made mistakes

@kuro68k
Copy link
Owner

kuro68k commented May 23, 2019

Thanks for your contribution.

Looking at it, you would need to create a fork for some of this stuff. For example, commenting out things you don't need has to be a fork, otherwise the main version will get those changes too. You can alternatively add a command line option to toggle them so that the default behaviour doesn't change.

I may have a little time to do more review and maybe some changes myself in the next few days.

@Robyrob
Copy link
Author

Robyrob commented May 23, 2019

Done, hope it works now. Let me know...
Thanks

@kuro68k
Copy link
Owner

kuro68k commented May 24, 2019

I'm just trying to understand what the quantity and number bugs are. You add one to them, is that right?

I'm thinking about how best to do the path stuff. Could make it so that if the config files don't exist under the same path as the BOM XML file it checks the program directory, or maybe add a separate path for them. The main issue is that if you don't keep those files with the project then the project isn't portable any more, but there is certainly a case for having them in a folder inside the project just to keep everything neat and tidy.

@Robyrob
Copy link
Author

Robyrob commented May 24, 2019

About No. in file output.cs you assigned 1 to int i then write it in No. column. I supposed you intended to have a progressive line number so I added "++" (row.Cells[0].AddParagraph(i++.ToString());) to increment it.

About Quantity I think you forgot to increment it by 1, as it is for other type of file generation and in fact quantity was wrong. Just adding "+1" (row.Cells[1].AddParagraph((c.count + 1).ToString());) solved.

......"I'm thinking about how best to do the path stuff. Could make it so that if the config files don't exist under the same path as the BOM XML file it checks the program directory"......
I think could be better than my solution.

......The main issue is that if you don't keep those files with the project then the project isn't portable any more, but there is certainly a case for having them in a folder inside the project just to keep everything neat and tidy........

You are right, but so I need to copy *.txt files to project folder every time.
Could be an idea to let kibom.exe copy them for you from kibom directory to project directory (if they doesn't exist already) and then use the local copy, so you can manage "general" componet and "local" component. What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants