add PGPORT environment variable to docker compose#399
Open
RobbyV2 wants to merge 1 commit intokurrier-org:mainfrom
Open
add PGPORT environment variable to docker compose#399RobbyV2 wants to merge 1 commit intokurrier-org:mainfrom
RobbyV2 wants to merge 1 commit intokurrier-org:mainfrom
Conversation
Contributor
|
Changing the Postgres port is typically environment-specific and something users can override locally rather than something we hardcode in main. Could you share the context for why this change is needed? If it’s to avoid a local port conflict, that would usually be handled per-user since everyone’s setup is different. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I faced some issues with setting up with the db, and I realized it was connecting to the default postgres port not respecting the setting in .env so adding a quick parameter to the compose for the bootstrapper fixed it